GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-105588: Add missing error checks to some `obj2ast_*` converters by brandtbucher · Pull Request #105589 · python/cpython

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Jun 9, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Some object-to-AST conversions are missing error checks #105588

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
brandtbucher added 4 commits June 9, 2023 11:00
@brandtbucher
Add failing regression tests
0546055
@brandtbucher
fixup
937af55
@brandtbucher
Add error checks after "product" node construction
45e92fe
@brandtbucher
blurb add
f8036bd
@brandtbucher brandtbucher added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 9, 2023
@brandtbucher brandtbucher self-assigned this Jun 9, 2023
@brandtbucher
brandtbucher requested a review from isidentical as a code owner June 9, 2023 19:04
@bedevere-bot bedevere-bot added the awaiting core review label Jun 9, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 9, 2023
Some object-to-AST conversions are missing error checks #105588
Closed
@furkanonder

furkanonder commented Jun 10, 2023

Copy link
Copy Markdown
Contributor

CC: @isidentical
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brandtbucher
brandtbucher merged commit a4056c8 into python:main Jun 15, 2023
@miss-islington

miss-islington commented Jun 15, 2023

Copy link
Copy Markdown
Contributor

Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 15, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 15, 2023
@brandtbucher @miss-islington
pythonGH-105588: Add missing error checks to some obj2ast_* converters (
f8c3966 
pythonGH-105589)

(cherry picked from commit a4056c8)

Co-authored-by: Brandt Bucher <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 15, 2023

Copy link
Copy Markdown

GH-105838 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 15, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 15, 2023
@brandtbucher @miss-islington
pythonGH-105588: Add missing error checks to some obj2ast_* converters (
3680071 
pythonGH-105589)

(cherry picked from commit a4056c8)

Co-authored-by: Brandt Bucher <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 15, 2023

Copy link
Copy Markdown

GH-105839 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 15, 2023
brandtbucher added a commit that referenced this pull request Jun 15, 2023
@miss-islington @brandtbucher
[3.12] GH-105588: Add missing error checks to some obj2ast_* converte…
0add516 
…rs (GH-105838)

GH-105588: Add missing error checks to some obj2ast_* converters (GH-105589)
(cherry picked from commit a4056c8)

Co-authored-by: Brandt Bucher <[email protected]>
brandtbucher added a commit that referenced this pull request Jun 15, 2023
@miss-islington @brandtbucher
[3.11] GH-105588: Add missing error checks to some obj2ast_* converte…
c0c4186 
…rs (GH-105839)

GH-105588: Add missing error checks to some obj2ast_* converters (GH-105589)
(cherry picked from commit a4056c8)

Co-authored-by: Brandt Bucher <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Jun 16, 2023
@carljm
Merge branch 'main' into modulelocals
b096651 
* main:
  pythongh-104799: PEP 695 backward compatibility for ast.unparse (python#105846)
  pythongh-105834: Add tests for calling `issubclass()` between two protocols (python#105835)
  CI: Remove docs build from Azure Pipelines (python#105823)
  pythongh-105844: Consistently use 'minor version' for X.Y versions (python#105851)
  Fix inaccuracies in "Assorted Topics" section of "Defining Extension Types" tutorial (python#104969)
  pythongh-105433: Add `pickle` tests for PEP695 (python#105443)
  bpo-44530: Document the change in MAKE_FUNCTION behavior (python#93189)
  pythonGH-103124: Multiline statement support for pdb (pythonGH-103125)
  pythonGH-105588: Add missing error checks to some obj2ast_* converters (pythonGH-105589)
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Jun 18, 2023
@brandtbucher @gvanrossum
pythonGH-105588: Add missing error checks to some obj2ast_* converters (
524490c 
pythonGH-105589)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isidentical isidentical Awaiting requested review from isidentical

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brandtbucher brandtbucher

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@brandtbucher @furkanonder @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.