GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105844: Use devguide terminology to denote versions by erlend-aasland · Pull Request #105882 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jun 17, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Clarify definition of "minor" vs "major" release #105844

📚 Documentation preview 📚: https://cpython-previews--105882.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@erlend-aasland
pythongh-105844: Use devguide terminology to denote versions
8828e0c
@erlend-aasland erlend-aasland added skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 17, 2023
@erlend-aasland
erlend-aasland requested review from AlexWaygood and CAM-Gerlach June 17, 2023 08:41
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir labels Jun 17, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 17, 2023
Clarify definition of "minor" vs "major" release #105844
Closed
erlend-aasland
erlend-aasland commented Jun 17, 2023
View reviewed changes
Comment thread Doc/install/index.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood
AlexWaygood approved these changes Jun 17, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 17, 2023
@AlexWaygood

AlexWaygood commented Jun 17, 2023

Copy link
Copy Markdown
Member

Not sure what's up with the doctest -- looks like all the individual doctests passed but Python segfaulted somewhere...?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CAM-Gerlach
CAM-Gerlach reviewed Jun 17, 2023
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread Doc/install/index.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland @CAM-Gerlach
Update Doc/install/index.rst
13d51cd
Co-authored-by: C.A.M. Gerlach <[email protected]>
CAM-Gerlach
CAM-Gerlach approved these changes Jun 18, 2023
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @erlend-aasland !

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@erlend-aasland

erlend-aasland commented Jun 18, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the reviews!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland
erlend-aasland merged commit dba7217 into python:main Jun 18, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 18, 2023
@miss-islington

miss-islington commented Jun 18, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2023
@erlend-aasland @miss-islington
pythongh-105844: Use devguide terminology to denote versions (pythonG…
a7e5d76
…H-105882)

(cherry picked from commit dba7217)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 18, 2023

Copy link
Copy Markdown

GH-105892 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 18, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2023
@erlend-aasland @miss-islington
pythongh-105844: Use devguide terminology to denote versions (pythonG…
118ac67
…H-105882)

(cherry picked from commit dba7217)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 18, 2023

Copy link
Copy Markdown

GH-105893 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 18, 2023
@erlend-aasland
erlend-aasland deleted the feature-release branch June 18, 2023 17:55
erlend-aasland added a commit that referenced this pull request Jun 18, 2023
@miss-islington @erlend-aasland
[3.11] gh-105844: Use devguide terminology to denote versions (GH-105882
043c831
) (#105893)

(cherry picked from commit dba7217)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request Jun 18, 2023
@miss-islington @erlend-aasland
[3.12] gh-105844: Use devguide terminology to denote versions (GH-105882
1606cbc
) (#105892)

(cherry picked from commit dba7217)

Co-authored-by: Erlend E. Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @AlexWaygood @miss-islington @bedevere-bot @CAM-Gerlach
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.