GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105879: Add support for keyword arguments to eval and exec by rtpg · Pull Request #105885 · python/cpython

Conversation

@rtpg

@rtpg rtpg commented Jun 17, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Allow eval and exec to take keyword arguments #105879

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
arhadthedev reacted with thumbs up emoji noamcohen97 reacted with hooray emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
@rtpg
Add support for keyword arguments to eval and exec (python#105879)
c4368ef
@bedevere-bot bedevere-bot added the awaiting review label Jun 17, 2023
@bedevere-bot

bedevere-bot commented Jun 17, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request Jun 17, 2023
Allow eval and exec to take keyword arguments #105879
Closed
@ghost

ghost commented Jun 17, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@blurb-it
📜🤖 Added by blurb_it.
62cad45
hauntsaninja
hauntsaninja approved these changes Jun 24, 2023
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for suggesting and adding this feature! I've definitely confused the ordering of these before :-) This looks good to me (although I think I still have a vague preference for keeping the source argument positional-only)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 24, 2023
@iritkatriel

iritkatriel commented Jun 25, 2023

Copy link
Copy Markdown
Member

Does this need a doc change?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rtpg

rtpg commented Jul 4, 2023

Copy link
Copy Markdown
Contributor Author

@iritkatriel i believe that the docstring changes (derived from the arg clinic changes) are sufficient, as I did not see anything being explicit about positional-only-ness beyond that
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra added 2 commits May 1, 2024 09:14
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into exec-kwargs
5a91d99
@JelleZijlstra
Undo unnecessary change
e86e93f
@JelleZijlstra JelleZijlstra self-assigned this May 1, 2024
@JelleZijlstra
Update docs
4cd0635
@rtpg
rtpg requested a review from ericsnowcurrently as a code owner May 1, 2024 16:21
@JelleZijlstra

JelleZijlstra commented May 1, 2024

Copy link
Copy Markdown
Member

I fixed the (trivial) merge conflict, undid an unnecessary formatting change, and added a documentation note as @iritkatriel suggested. I'll merge the PR in a bit so we can get this change into 3.13.
rtpg reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra added 2 commits May 1, 2024 09:24
@JelleZijlstra
Fix name of parameter
b994e9d
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into exec-kwargs
bd47bf3
@JelleZijlstra

JelleZijlstra commented May 2, 2024

Copy link
Copy Markdown
Member

Thinking about it again I agree with @hauntsaninja's suggestion above that we should leave the first argument positional-only. I'll make that change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
Leave first param pos-only
6172dbf
@JelleZijlstra
JelleZijlstra merged commit 2770d5c into python:main May 2, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 2, 2024
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@rtpg @JelleZijlstra @SonicField
pythongh-105879: Add support for keyword arguments to eval and exec (p…
b2ff973 
…ython#105885)

Co-authored-by: Jelle Zijlstra <[email protected]>
@vadmium vadmium mentioned this pull request Aug 15, 2025
Clarify documentation of positional-only default values #67926
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@rtpg @bedevere-bot @iritkatriel @JelleZijlstra @hauntsaninja
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.