GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105908: fix `barry_as_FLUFL` future import by thatbirdguythatuknownot · Pull Request #105909 · python/cpython

Conversation

@thatbirdguythatuknownot

@thatbirdguythatuknownot thatbirdguythatuknownot commented Jun 19, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

In compiler_setup(), the flags parameter is a local struct that does not reflect changes to the pointer passed to new_compiler(). Fix by making the flags parameter a pointer to a struct instead of a struct.

  • Issue: syntactical __future__ import barry_as_FLUFL does not work in the REPL anymore #105908

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@thatbirdguythatuknownot
pass in a pointer of flags to compiler_setup instead of a struct
57f5a47
@thatbirdguythatuknownot
thatbirdguythatuknownot requested review from iritkatriel and markshannon as code owners June 19, 2023 10:45
@bedevere-bot bedevere-bot added the awaiting review label Jun 19, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 19, 2023
syntactical __future__ import barry_as_FLUFL does not work in the REPL anymore #105908
Closed
@iritkatriel

iritkatriel commented Jun 19, 2023

Copy link
Copy Markdown
Member

Is there no test for this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@thatbirdguythatuknownot

thatbirdguythatuknownot commented Jun 19, 2023

Copy link
Copy Markdown
Contributor Author

Is there no test for this?

I'm currently adding it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
blurb-it Bot and others added 2 commits June 19, 2023 11:04
@blurb-it
📜🤖 Added by blurb_it.
28aa0f8
@thatbirdguythatuknownot
add checks for barry_as_FLUFL import in REPL
0ce3aab
Eclips4
Eclips4 reviewed Jun 19, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2023-06-19-11-04-01.gh-issue-105908.7oanny.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@thatbirdguythatuknownot @Eclips4
fix news markdown
6815da7 
Co-authored-by: Kirill Podoprigora <[email protected]>
iritkatriel
iritkatriel approved these changes Jun 19, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 19, 2023
@iritkatriel

iritkatriel commented Jun 19, 2023

Copy link
Copy Markdown
Member

Thank you @thatbirdguythatuknownot .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel iritkatriel added the type-bug An unexpected behavior, bug, or error label Jun 19, 2023
@iritkatriel
Merge branch 'main' into patch-31
9bb5ff7
@iritkatriel

iritkatriel commented Jun 19, 2023

Copy link
Copy Markdown
Member

@thatbirdguythatuknownot there is a test failure in the "Address sanitizer" test. Is it due to this PR?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@thatbirdguythatuknownot

thatbirdguythatuknownot commented Jun 19, 2023

Copy link
Copy Markdown
Contributor Author

@thatbirdguythatuknownot there is a test failure in the "Address sanitizer" test. Is it due to this PR?

It must be from flags = &_PyCompilerFlags_INIT. I could probably bring back the local_flags variable to prevent it.
iritkatriel reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@thatbirdguythatuknownot
add local_flags variable back to prevent stack use-after-free
f78b151
@iritkatriel
iritkatriel merged commit 28187a9 into python:main Jun 19, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 19, 2023
@sunmy2019

sunmy2019 commented Jun 20, 2023

Copy link
Copy Markdown
Member

Thanks! This change makes sense.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra

JelleZijlstra commented Jun 20, 2023

Copy link
Copy Markdown
Member

Does this need to be backported to 3.12?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra added the needs backport to 3.12 only security fixes label Jun 20, 2023
@miss-islington

miss-islington commented Jun 20, 2023

Copy link
Copy Markdown
Contributor

Thanks @thatbirdguythatuknownot for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jun 20, 2023

Copy link
Copy Markdown

GH-105930 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 20, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 20, 2023
@thatbirdguythatuknownot @miss-islington
pythongh-105908: fix barry_as_FLUFL future import (pythonGH-105909)
32335a2 
(cherry picked from commit 28187a9)

Co-authored-by: Crowthebird <[email protected]>
JelleZijlstra pushed a commit that referenced this pull request Jun 20, 2023
@miss-islington @thatbirdguythatuknownot
[3.12] gh-105908: fix barry_as_FLUFL future import (GH-105909) (#10…
cc18a8b 
…5930)

(cherry picked from commit 28187a9)

Co-authored-by: Crowthebird <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 left review comments
@iritkatriel iritkatriel iritkatriel approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@thatbirdguythatuknownot @iritkatriel @sunmy2019 @JelleZijlstra @miss-islington @bedevere-bot @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.