GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] GH-105808: Fix a regression introduced in GH-101251 (GH-105910) by miss-islington · Pull Request #105920 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 19, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix a regression introduced in GH-101251, causing GzipFile.flush() to
not flush the compressor (nor pass along the zip_mode argument).
(cherry picked from commit 1858db7)

Co-authored-by: T. Wouters [email protected]

  • Issue: GzipFile.flush doesn't flush compressor in 3.12 beta #105808

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Yhg1s @miss-islington
pythonGH-105808: Fix a regression introduced in pythonGH-101251 (pyth…
15b4976 
…onGH-105910)

Fix a regression introduced in pythonGH-101251, causing GzipFile.flush() to
not flush the compressor (nor pass along the zip_mode argument).
(cherry picked from commit 1858db7)

Co-authored-by: T. Wouters <[email protected]>
@bedevere-bot bedevere-bot added the awaiting review label Jun 19, 2023
This was referenced Jun 19, 2023
GzipFile.flush doesn't flush compressor in 3.12 beta #105808
Closed
GH-105808: Fix a regression introduced in GH-101251 #105910
Merged
@Yhg1s
Yhg1s enabled auto-merge (squash) June 19, 2023 17:11
Yhg1s
Yhg1s approved these changes Jun 19, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 19, 2023
@Yhg1s
Yhg1s merged commit 225cc4c into python:3.12 Jun 19, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 19, 2023
@miss-islington
miss-islington deleted the backport-1858db7-3.12 branch June 19, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yhg1s Yhg1s Yhg1s approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @Yhg1s @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.