GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-105808: Fix a regression introduced in GH-101251 by Yhg1s · Pull Request #105910 · python/cpython

Conversation

@Yhg1s

@Yhg1s Yhg1s commented Jun 19, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fix a regression introduced in GH-101251, causing GzipFile.flush() to not flush the compressor (nor pass along the zip_mode argument).

  • Issue: GzipFile.flush doesn't flush compressor in 3.12 beta #105808

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Yhg1s
Fix a regression introduced in pythonGH-101251, causing GzipFile.flus…
5b3a658 
…h() to

not flush the compressor (nor pass along the zip_mode argument).
@bedevere-bot bedevere-bot added the awaiting core review label Jun 19, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 19, 2023
GzipFile.flush doesn't flush compressor in 3.12 beta #105808
Closed
blurb-it Bot and others added 2 commits June 19, 2023 11:32
@blurb-it
📜🤖 Added by blurb_it.
353d8af
@Yhg1s
Merge branch 'main' into gzip-flush
1ab6bd8
@Yhg1s
Yhg1s requested review from ambv and gpshead June 19, 2023 11:32
@gpshead
ReSTify the NEWS.
43cbbd3
gpshead
gpshead approved these changes Jun 19, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 19, 2023
@gpshead gpshead added the needs backport to 3.12 only security fixes label Jun 19, 2023
@gpshead
gpshead enabled auto-merge (squash) June 19, 2023 16:40
@gpshead
gpshead merged commit 1858db7 into python:main Jun 19, 2023
@miss-islington

miss-islington commented Jun 19, 2023

Copy link
Copy Markdown
Contributor

Thanks @Yhg1s for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 19, 2023
@bedevere-bot

bedevere-bot commented Jun 19, 2023

Copy link
Copy Markdown

GH-105920 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2023
@Yhg1s @miss-islington
pythonGH-105808: Fix a regression introduced in pythonGH-101251 (pyth…
15b4976 
…onGH-105910)

Fix a regression introduced in pythonGH-101251, causing GzipFile.flush() to
not flush the compressor (nor pass along the zip_mode argument).
(cherry picked from commit 1858db7)

Co-authored-by: T. Wouters <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 19, 2023
Yhg1s added a commit that referenced this pull request Jun 19, 2023
@miss-islington @Yhg1s
[3.12] GH-105808: Fix a regression introduced in GH-101251 (GH-105910) (
225cc4c 
#105920)

GH-105808: Fix a regression introduced in GH-101251 (GH-105910)

Fix a regression introduced in GH-101251, causing GzipFile.flush() to
not flush the compressor (nor pass along the zip_mode argument).
(cherry picked from commit 1858db7)

Co-authored-by: T. Wouters <[email protected]>
@Yhg1s
Yhg1s deleted the gzip-flush branch November 22, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@ambv ambv Awaiting requested review from ambv

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Yhg1s @miss-islington @bedevere-bot @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.