GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-89812: Add `pathlib.UnsupportedOperation` by barneygale · Pull Request #105926 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented Jun 19, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This new exception type is raised instead of NotImplementedError when a path operation is not supported. It can be raised from Path.readlink(), symlink_to(), hardlink_to(), owner() and group(). In a future version of pathlib, it will be raised by AbstractPath for these methods and others, such as AbstractPath.mkdir() and unlink().

  • Issue: Add tarfile.TarPath #89812

📚 Documentation preview 📚: https://cpython-previews--105926.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@barneygale
pythonGH-89812: Add pathlib.UnsupportedOperation
8ca08fc 
This new exception type is raised instead of `NotImplementedError` when
a path operation is not supported. It can be raised from `Path.readlink()`,
`symlink_to()`, `hardlink_to()`, `owner()` and `group()`. In a future
version of pathlib, it will be raised by `AbstractPath` for these methods
and others, such as `AbstractPath.mkdir()` and `unlink()`.
@barneygale barneygale added the topic-pathlib label Jun 19, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jun 19, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 15, 2023
Add tarfile.TarPath #89812
Open
@barneygale barneygale changed the title GH-89812: Add pathlib.UnsupportedOperation GH-89812: Add pathlib.UnsupportedOperation Jun 19, 2023
@barneygale
barneygale requested a review from encukou June 19, 2023 22:16
@encukou

encukou commented Jun 21, 2023

Copy link
Copy Markdown
Member

Looks good, thank you!

I'd add versionadded notes to the docs of all the functions, since we can't expect readers to check the docs for UnsupportedOperation.
barneygale reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale
Tweak docs
b3aed1f
@barneygale

barneygale commented Jun 21, 2023

Copy link
Copy Markdown
Contributor Author

Good shout, thank you. I've done it via .. versionchanged directives on each method - does it look OK?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale
Add versionchanged directives to PosixPath and WindowsPath
40ab724
encukou
encukou approved these changes Jun 22, 2023
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 22, 2023
@barneygale

barneygale commented Jun 22, 2023

Copy link
Copy Markdown
Contributor Author

Thanks very much for the idea and review!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale
barneygale merged commit a800670 into python:main Jun 22, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 22, 2023
bentasker pushed a commit to bentasker/cpython that referenced this pull request Jun 23, 2023
@barneygale @bentasker
pythonGH-89812: Add pathlib.UnsupportedOperation (pythonGH-105926)
8fd3e13 
This new exception type is raised instead of `NotImplementedError` when
a path operation is not supported. It can be raised from `Path.readlink()`,
`symlink_to()`, `hardlink_to()`, `owner()` and `group()`. In a future
version of pathlib, it will be raised by `AbstractPath` for these methods
and others, such as `AbstractPath.mkdir()` and `unlink()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@barneygale @encukou @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.