GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-105481: refactor instr flag related code into a new InstructionFlags class by iritkatriel · Pull Request #105950 · python/cpython

Conversation

iritkatriel commented Jun 20, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

save the complete flags data on the instruction (not just the bitmap)
refactor all the code into a new flag management class.

This will help later when we want to use the flags for things like generating hasarg, etc.

Issue: Generate opcode metadata from bytecodes.c instead of opcode.py #105481

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-105481: refactor instr flag related code into a new Instruct…

bb43ee8

…ionFlags class

bedevere-bot added the awaiting core review label

Jun 20, 2023

bedevere-bot mentioned this pull request

Jun 20, 2023

Generate opcode metadata from bytecodes.c instead of opcode.py #105481

Closed

iritkatriel added the skip news label

Jun 20, 2023

iritkatriel requested a review from gvanrossum

June 20, 2023 22:42

gvanrossum reviewed

Jun 20, 2023

View reviewed changes

gvanrossum left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like refactoring this, but I'd like to go a little beyond just packaging up the old code in a class.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Tools/cases_generator/generate_cases.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Tools/cases_generator/generate_cases.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Tools/cases_generator/generate_cases.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Tools/cases_generator/generate_cases.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Tools/cases_generator/generate_cases.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Tools/cases_generator/generate_cases.py

		format += cache
		cache = "0"
		flags \|= instr.flags
		flags.add(instr.instr_flags)

gvanrossum Jun 20, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, in my optimizer work, I have a need to prevent one flag ("IS_UOP") from being propagated. How would you do that using the new API?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

iritkatriel Jun 21, 2023

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add an arg to this function to tell it which flags to skip?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

gvanrossum Jun 21, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, something like exclude: set[str] | None = None would work.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

iritkatriel Jun 21, 2023

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add it when we need it. I don't like adding code that is neither used nor tested.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gvanrossum reacted with thumbs up emoji

All reactions

👍 1 reaction

gvanrossum Jun 21, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add it after I merge your code into gh-105924.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Tools/cases_generator/generate_cases.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Tools/cases_generator/generate_cases.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Tools/cases_generator/generate_cases.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Tools/cases_generator/generate_cases.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

iritkatriel added 2 commits

June 21, 2023 11:30


          code review comments

a08ac66


          make InstructionFlags a dataclass

8fcd65f

gvanrossum reviewed

Jun 21, 2023

View reviewed changes

Comment thread

Tools/cases_generator/generate_cases.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          remove __hash__ and __eq__

d383eaa

gvanrossum approved these changes

Jun 21, 2023

View reviewed changes

gvanrossum left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting core review labels

Jun 21, 2023

iritkatriel commented Jun 21, 2023

Copy link

Copy Markdown

Member Author

It's doing this now that I removed the hash and eq:

Traceback (most recent call last):
  File "/Users/iritkatriel/src/cpython-1/./Tools/cases_generator/generate_cases.py", line 1422, in <module>
    main()
  File "/Users/iritkatriel/src/cpython-1/./Tools/cases_generator/generate_cases.py", line 1414, in main
    a.analyze()  # Prints messages and sets a.errors on failure
    ^^^^^^^^^^^
  File "/Users/iritkatriel/src/cpython-1/./Tools/cases_generator/generate_cases.py", line 708, in analyze
    self.analyze_macros_and_pseudos()
  File "/Users/iritkatriel/src/cpython-1/./Tools/cases_generator/generate_cases.py", line 827, in analyze_macros_and_pseudos
    self.pseudo_instrs[name] = self.analyze_pseudo(pseudo)
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/iritkatriel/src/cpython-1/./Tools/cases_generator/generate_cases.py", line 865, in analyze_pseudo
    flags_list = list(set([t.instr_flags for t in targets]))
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: unhashable type: 'InstructionFlags'

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gvanrossum commented Jun 21, 2023

Copy link

Copy Markdown

Member

It's doing this now that I removed the hash and eq:

Traceback (most recent call last):
[...]
  File "/Users/iritkatriel/src/cpython-1/./Tools/cases_generator/generate_cases.py", line 865, in analyze_pseudo
    flags_list = list(set([t.instr_flags for t in targets]))
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: unhashable type: 'InstructionFlags'

Oh dang. Dataclasses don't generate a hash by default. You can either put the __hash__ back or write @dataclass(unsafe_hash=True). The "unsafe" part concerns me.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          hash the bitmap instead of the InstructionFlags object

f34174d

gvanrossum approved these changes

Jun 21, 2023

View reviewed changes

gvanrossum left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works too!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

iritkatriel commented Jun 21, 2023

Copy link

Copy Markdown

Member Author

I changed it to not hash the data class object but the bitmap representation. It's just for an assertion that all the flags of a pseudo-op's targets are the same.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iritkatriel enabled auto-merge (squash)

June 21, 2023 22:51

iritkatriel merged commit c01da28 into python:main

Jun 21, 2023

bedevere-bot removed the awaiting merge label

Jun 21, 2023

gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request

Jun 22, 2023


          pythongh-105481: refactor instr flag related code into a new Instruct…

6d532c7

…ionFlags class (python#105950)

bentasker pushed a commit to bentasker/cpython that referenced this pull request

Jun 23, 2023


          pythongh-105481: refactor instr flag related code into a new Instruct…

deaaa08

…ionFlags class (python#105950)

iritkatriel deleted the flags branch

July 25, 2023 18:02

Reviewers

gvanrossum

gvanrossum approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

iritkatriel commented Jun 20, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gvanrossum Jun 20, 2023

Choose a reason for hiding this comment

Uh oh!

iritkatriel Jun 21, 2023

Choose a reason for hiding this comment

Uh oh!

gvanrossum Jun 21, 2023

Choose a reason for hiding this comment

Uh oh!

iritkatriel Jun 21, 2023

Choose a reason for hiding this comment

Uh oh!

gvanrossum Jun 21, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

iritkatriel commented Jun 21, 2023

Uh oh!

gvanrossum commented Jun 21, 2023

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

iritkatriel commented Jun 21, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

iritkatriel commented Jun 20, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.