GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-98931: Add custom error messages to invalid import/from with multiple targets (GH-105985) by miss-islington · Pull Request #105991 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 22, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 13237a2)

Co-authored-by: Pablo Galindo Salgado [email protected]
Co-authored-by: Alex Waygood [email protected]

  • Issue: Improve syntax error for invalid imports #98931

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal @AlexWaygood @miss-islington
pythongh-98931: Add custom error messages to invalid import/from with…
0bb8b06 
… multiple targets (pythonGH-105985)

(cherry picked from commit 13237a2)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
@miss-islington
miss-islington requested review from lysnikolaou and pablogsal as code owners June 22, 2023 15:56
@bedevere-bot bedevere-bot added the awaiting review label Jun 22, 2023
This was referenced Jun 22, 2023
Improve syntax error for invalid imports #98931
Closed
gh-98931: Add custom error messages to invalid import/from with multiple targets #105985
Merged
pablogsal
pablogsal approved these changes Jun 22, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 22, 2023
@pablogsal
pablogsal enabled auto-merge (squash) June 22, 2023 16:02
@pablogsal
pablogsal merged commit c407ef0 into python:3.12 Jun 22, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 22, 2023
@miss-islington
miss-islington deleted the backport-13237a2-3.12 branch June 22, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @pablogsal @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.