GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98931: Add custom error messages to invalid import/from with multiple targets by pablogsal · Pull Request #105985 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Jun 22, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Improve syntax error for invalid imports #98931

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pablogsal requested a review from lysnikolaou as a code owner June 22, 2023 13:20
@bedevere-bot bedevere-bot added the awaiting core review label Jun 22, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 7, 2023
Improve syntax error for invalid imports #98931
Closed
@pablogsal

pablogsal commented Jun 22, 2023

Copy link
Copy Markdown
Member Author

@Yhg1s This is technically not a new error message but somehow an oversight (multiple targets were not supported). Are you ok adding this to 3.12?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Yhg1s

Yhg1s commented Jun 22, 2023

Copy link
Copy Markdown
Member

Yeah, 👍 for getting this into 3.12b4.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Yhg1s
Yhg1s approved these changes Jun 22, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 22, 2023
@pablogsal pablogsal added the needs backport to 3.12 only security fixes label Jun 22, 2023
@pablogsal
pythongh-98931: Add custom error messages to invalid import/from with…
594e24f 
… multiple targets

Signed-off-by: Pablo Galindo <[email protected]>
@pablogsal
pablogsal force-pushed the gh-98931-2 branch from 78e213d to 594e24f Compare June 22, 2023 15:12
AlexWaygood
AlexWaygood reviewed Jun 22, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2023-06-22-14-19-17.gh-issue-98931.PPgvSF.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal @AlexWaygood
Update Misc/NEWS.d/next/Core and Builtins/2023-06-22-14-19-17.gh-issu…
37d439e 
…e-98931.PPgvSF.rst

Co-authored-by: Alex Waygood <[email protected]>
@pablogsal
pablogsal enabled auto-merge (squash) June 22, 2023 15:40
@pablogsal
pablogsal merged commit 13237a2 into python:main Jun 22, 2023
@pablogsal
pablogsal deleted the gh-98931-2 branch June 22, 2023 15:56
@miss-islington

miss-islington commented Jun 22, 2023

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 22, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 22, 2023
@pablogsal @AlexWaygood @miss-islington
pythongh-98931: Add custom error messages to invalid import/from with…
0bb8b06 
… multiple targets (pythonGH-105985)

(cherry picked from commit 13237a2)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 22, 2023

Copy link
Copy Markdown

GH-105991 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 22, 2023
pablogsal added a commit that referenced this pull request Jun 22, 2023
@miss-islington @pablogsal @AlexWaygood
[3.12] gh-98931: Add custom error messages to invalid import/from wit…
c407ef0 
…h multiple targets (GH-105985) (#105991)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
bentasker pushed a commit to bentasker/cpython that referenced this pull request Jun 23, 2023
@pablogsal @AlexWaygood @bentasker
pythongh-98931: Add custom error messages to invalid import/from with…
44bea61 
… multiple targets (python#105985)

Co-authored-by: Alex Waygood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments
@Yhg1s Yhg1s Yhg1s approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@pablogsal @Yhg1s @miss-islington @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.