GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105063: Disable test_peg_generator.TestCParser bco. ref leaks by erlend-aasland · Pull Request #106024 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jun 23, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Since gh-104798 (Use setuptools in peg-generator and reenable
tests), the TestCParser test case has been producing ref leaks.

  • Issue: test_peg_generator leaks references #105063

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-105063: Disable test_peg_generator.TestCParser bco. ref leaks
97a988b 
Since pythongh-104798 (Use setuptools in peg-generator and reenable
tests), the TestCParser test case has been producing ref leaks.
@erlend-aasland
erlend-aasland requested review from lysnikolaou and pablogsal as code owners June 23, 2023 14:02
@erlend-aasland erlend-aasland added the skip news label Jun 23, 2023
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 23, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 23, 2023
test_peg_generator leaks references #105063
Open
@erlend-aasland

erlend-aasland commented Jun 23, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Let's wait for gh-106013 to be merged, before running the ref leak bots.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lysnikolaou
lysnikolaou approved these changes Jun 23, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 23, 2023
@erlend-aasland
erlend-aasland merged commit 41ad4df into python:main Jun 23, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 23, 2023
@erlend-aasland
erlend-aasland deleted the disable-peg-gen-tests branch June 23, 2023 17:04
@lysnikolaou lysnikolaou added the needs backport to 3.12 only security fixes label Jul 5, 2023
@miss-islington

miss-islington commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 5, 2023
@erlend-aasland @miss-islington
pythongh-105063: Disable test_peg_generator.TestCParser bco. ref leaks (
c8b2a49 
pythonGH-106024)

Since pythongh-104798 (Use setuptools in peg-generator and reenable
tests), the TestCParser test case has been producing ref leaks.
(cherry picked from commit 41ad4df)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 5, 2023

Copy link
Copy Markdown

GH-106450 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 5, 2023
ambv pushed a commit that referenced this pull request Jul 5, 2023
@miss-islington @erlend-aasland
[3.12] gh-105063: Disable test_peg_generator.TestCParser bco. ref lea…
b314194 
…ks (GH-106024) (#106450)

Since gh-104798 (Use setuptools in peg-generator and reenable
tests), the TestCParser test case has been producing ref leaks.
(cherry picked from commit 41ad4df)

Co-authored-by: Erlend E. Aasland <[email protected]>
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Sep 23, 2025
@StanFromIreland
Revert "pythongh-105063: Disable test_peg_generator.TestCParser bco. …
2703e9a 
…ref leaks (python#106024)"

This reverts commit 41ad4df.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @miss-islington @bedevere-bot @lysnikolaou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.