GeezerVison is showing github.com — GH-89812: Simplify creation of symlinks in pathlib tests. by barneygale · Pull Request #106061 · python/cpython
Conversation
barneygale
commented
Jun 24, 2023
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Remove PathTest.dirlink() function. Symlinks in PathTest.setUp() are created using os.symlink() directly; symlinks in test functions use Path.symlink_to() in order to make the tests applicable to a (near-)future AbstractPath class.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Remove `PathTest.dirlink()` function. Symlinks in `PathTest.setUp()` are
created using `os.symlink()` directly; symlinks in test functions use
`Path.symlink_to()` in order to make the tests applicable to a
(near-)future `AbstractPath` class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert on symlink handling, but while it does make the test code slightly less concise, there appears to be a motivated reason to do so, it eliminates a workaround, and is needed for future improvements. I also couldn't spot any obvious issues in the implementation, though again, I defer to Barney and others regarding SME issues.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Thank you for the review CAM!
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
manosriram
pushed a commit
to manosriram/cpython
that referenced
this pull request
Jul 1, 2023
…onGH-106061)
Remove `PathTest.dirlink()` function. Symlinks in `PathTest.setUp()` are
created using `os.symlink()` directly; symlinks in test functions use
`Path.symlink_to()` in order to make the tests applicable to a
(near-)future `AbstractPath` class.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.