GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-106123: Modules/_sha3 appears to no longer be necessary (GH-106124) by miss-islington · Pull Request #106127 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 27, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 0345b0c)

Co-authored-by: Skip Montanaro [email protected]

  • Issue: Modules/_sha3 is created by configure, but no longer an actual source directory #106123

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@smontanaro @miss-islington
pythongh-106123: Modules/_sha3 appears to no longer be necessary (pyt…
1ae5868 
…honGH-106124)

(cherry picked from commit 0345b0c)

Co-authored-by: Skip Montanaro <[email protected]>
@miss-islington
miss-islington requested review from corona10 and erlend-aasland as code owners June 27, 2023 03:40
@bedevere-bot bedevere-bot added the awaiting review label Jun 27, 2023
This was referenced Jun 27, 2023
Modules/_sha3 is created by configure, but no longer an actual source directory #106123
Closed
gh-106123: Modules/_sha3 appears to no longer be necessary #106124
Merged
@bedevere-bot bedevere-bot added the skip news label Jun 27, 2023
hauntsaninja
hauntsaninja approved these changes Jun 27, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 27, 2023
@hauntsaninja
hauntsaninja merged commit 0efbe4d into python:3.12 Jun 27, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 27, 2023
@miss-islington
miss-islington deleted the backport-0345b0c-3.12 branch June 27, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @hauntsaninja @bedevere-bot @smontanaro
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.