GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106123: Modules/_sha3 appears to no longer be necessary by smontanaro · Pull Request #106124 · python/cpython

Conversation

@smontanaro

@smontanaro smontanaro commented Jun 26, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This is a pretty trivial PR. I'm guessing Modules/_sha3 was a holdover from before Modules/_hacl existed. Perhaps there's a valid reason for it to still exist (used on another platform?), but if so, maybe it should be described in a comment in configure.ac

  • Issue: Modules/_sha3 is created by configure, but no longer an actual source directory #106123

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@smontanaro
Modules/_sha3 appears to no longer be necessary
c0079d8
@smontanaro
smontanaro requested review from corona10 and erlend-aasland as code owners June 26, 2023 21:33
@bedevere-bot bedevere-bot added the awaiting review label Jun 26, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 26, 2023
Modules/_sha3 is created by configure, but no longer an actual source directory #106123
Closed
erlend-aasland
erlend-aasland approved these changes Jun 26, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 26, 2023
@erlend-aasland erlend-aasland added awaiting review needs backport to 3.12 only security fixes skip news and removed awaiting merge labels Jun 26, 2023
@erlend-aasland

erlend-aasland commented Jun 26, 2023

Copy link
Copy Markdown
Contributor

Thanks, Skip! Can you do a make regen-configure and commit the changes?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@smontanaro
ran make regen-configure
64618b3
sunmy2019
sunmy2019 approved these changes Jun 27, 2023
View reviewed changes

@sunmy2019 sunmy2019 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
hauntsaninja
hauntsaninja approved these changes Jun 27, 2023
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was indeed removed in #103597

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 27, 2023
@hauntsaninja
hauntsaninja merged commit 0345b0c into python:main Jun 27, 2023
@miss-islington

miss-islington commented Jun 27, 2023

Copy link
Copy Markdown
Contributor

Thanks @smontanaro for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 27, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2023
@smontanaro @miss-islington
pythongh-106123: Modules/_sha3 appears to no longer be necessary (pyt…
1ae5868 
…honGH-106124)

(cherry picked from commit 0345b0c)

Co-authored-by: Skip Montanaro <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 27, 2023

Copy link
Copy Markdown

GH-106127 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 27, 2023
hauntsaninja pushed a commit that referenced this pull request Jun 27, 2023
@miss-islington @smontanaro
[3.12] gh-106123: Modules/_sha3 appears to no longer be necessary (GH…
0efbe4d 
…-106124) (#106127)

Co-authored-by: Skip Montanaro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes
@erlend-aasland erlend-aasland erlend-aasland approved these changes
@sunmy2019 sunmy2019 sunmy2019 approved these changes
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@smontanaro @erlend-aasland @miss-islington @bedevere-bot @hauntsaninja @sunmy2019
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.