GeezerVison is showing github.com — gh-106316: Remove pytime.h header file by vstinner · Pull Request #106317 · python/cpython
Conversation
vstinner
commented
Jul 1, 2023
•
edited by github-actions
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Remove the "cpython/pytime.h" header file: it only contained private functions. Move functions to the internal pycore_time.h header file.
Move tests from _testcapi to _testinternalcapi. Rename also test methods to have the same name than tested C functions.
No longer export these functions:
- _PyTime_Add()
- _PyTime_As100Nanoseconds()
- _PyTime_FromMicrosecondsClamp()
- _PyTime_FromTimespec()
- _PyTime_FromTimeval()
- _PyTime_GetPerfCounterWithInfo()
- _PyTime_MulDiv()
📚 Documentation preview 📚: https://cpython-previews--106317.org.readthedocs.build/
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Remove the "cpython/pytime.h" header file: it only contained private
functions. Move functions to the internal pycore_time.h header file.
Move tests from _testcapi to _testinternalcapi. Rename also test
methods to have the same name than tested C functions.
No longer export these functions:
* _PyTime_Add()
* _PyTime_As100Nanoseconds()
* _PyTime_FromMicrosecondsClamp()
* _PyTime_FromTimespec()
* _PyTime_FromTimeval()
* _PyTime_GetPerfCounterWithInfo()
* _PyTime_MulDiv()
vstinner
requested review from
a team,
abalkin,
brettcannon,
encukou,
ericsnowcurrently,
ezio-melotti,
hugovk,
ncoghlan,
pganssle,
rhettinger and
warsaw
as
code owners
July 1, 2023 19:43
encukou
added a commit
to encukou/cpython
that referenced
this pull request
Feb 12, 2024
…ader file (python#106317)"
This reverts commit 46d7761,
and returns to the status quo (3.12).
Tests are left in _testinternalcapi; this sounds appropriate for
underscored functions.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.