GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-106396: Special-case empty format spec to gen empty JoinedStr node (GH-106401) by miss-islington · Pull Request #106416 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 4, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit dfe4de2)

Co-authored-by: Lysandros Nikolaou [email protected]

  • Issue: f'"{var:}"' adds redundant empty string literal in AST in 3.12 #106396

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lysnikolaou @miss-islington
pythongh-106396: Special-case empty format spec to gen empty JoinedSt…
741e919 
…r node (pythonGH-106401)

(cherry picked from commit dfe4de2)

Co-authored-by: Lysandros Nikolaou <[email protected]>
@miss-islington
miss-islington requested review from lysnikolaou and pablogsal as code owners July 4, 2023 12:19
@bedevere-bot bedevere-bot added the awaiting review label Jul 4, 2023
This was referenced Jul 4, 2023
f'"{var:}"' adds redundant empty string literal in AST in 3.12 #106396
Closed
gh-106396: Special-case empty format spec to gen empty JoinedStr node #106401
Merged
lysnikolaou
lysnikolaou approved these changes Jul 4, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jul 4, 2023
@lysnikolaou
lysnikolaou enabled auto-merge (squash) July 4, 2023 12:20
@lysnikolaou
lysnikolaou merged commit 930df7b into python:3.12 Jul 4, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 4, 2023
@miss-islington
miss-islington deleted the backport-dfe4de2-3.12 branch July 4, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @lysnikolaou @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.