GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106396: Special-case empty format spec to gen empty JoinedStr node by lysnikolaou · Pull Request #106401 · python/cpython

Conversation

@lysnikolaou

@lysnikolaou lysnikolaou commented Jul 4, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: f'"{var:}"' adds redundant empty string literal in AST in 3.12 #106396

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@lysnikolaou
pythongh-106396: Special-case empty format spec to gen empty JoinedSt…
a6152ae
…r node
@lysnikolaou
lysnikolaou requested a review from pablogsal as a code owner July 4, 2023 09:45
@bedevere-bot bedevere-bot added the awaiting core review label Jul 4, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 4, 2023
f'"{var:}"' adds redundant empty string literal in AST in 3.12 #106396
Closed
@lysnikolaou lysnikolaou added the needs backport to 3.12 only security fixes label Jul 4, 2023
blurb-it Bot and others added 2 commits July 4, 2023 09:51
@blurb-it
📜🤖 Added by blurb_it.
be54786
@lysnikolaou
Improve NEWS blurb
e13e90c
@AlexWaygood AlexWaygood mentioned this pull request Jul 4, 2023
Fix parse test case on Python 3.12 python/mypy#15577
Merged
pablogsal
pablogsal approved these changes Jul 4, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 4, 2023
pablogsal
pablogsal reviewed Jul 4, 2023
View reviewed changes
Comment thread Parser/action_helpers.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@lysnikolaou
Add comment
85ebc86
@lysnikolaou
lysnikolaou force-pushed the fstring-empty-format-spec branch from 03ab852 to 85ebc86 Compare July 4, 2023 11:22
@lysnikolaou
lysnikolaou merged commit dfe4de2 into python:main Jul 4, 2023
@miss-islington

miss-islington commented Jul 4, 2023

Copy link
Copy Markdown
Contributor

Thanks @lysnikolaou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label Jul 4, 2023
@lysnikolaou
lysnikolaou deleted the fstring-empty-format-spec branch July 4, 2023 12:19
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 4, 2023
@lysnikolaou @miss-islington
pythongh-106396: Special-case empty format spec to gen empty JoinedSt…
741e919
…r node (pythonGH-106401)

(cherry picked from commit dfe4de2)

Co-authored-by: Lysandros Nikolaou <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 4, 2023

Copy link
Copy Markdown

GH-106416 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 4, 2023
lysnikolaou added a commit that referenced this pull request Jul 4, 2023
@miss-islington @lysnikolaou
[3.12] gh-106396: Special-case empty format spec to gen empty JoinedS…
930df7b
…tr node (GH-106401) (#106416)

(cherry picked from commit dfe4de2)

Co-authored-by: Lysandros Nikolaou <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Jul 5, 2023
@carljm
Merge branch 'main' into modulelocals
4c59e51
* main: (39 commits)
  pythongh-102542 Remove unused bytes object and bytes slicing (python#106433)
  Clarify state of CancelledError in doc (python#106453)
  pythongh-64595: Fix regression in file write logic in Argument Clinic (python#106449)
  pythongh-104683: Rename Lib/test/clinic.test as Lib/test/clinic.test.c (python#106443)
  tp_flags docs: fix indentation (python#106420)
  pythongh-104050: Partially annotate Argument Clinic CLanguage class (python#106437)
  pythongh-106368: Add tests for formatting helpers in Argument Clinic (python#106415)
  pythongh-104050: Annotate Argument Clinic parameter permutation helpers (python#106431)
  pythongh-104050: Annotate toplevel functions in clinic.py (python#106435)
  pythongh-106320: Fix specialize.c compilation by including pycore_pylifecycle.h (python#106434)
  Add some codeowners for `Tools/clinic/` (python#106430)
  pythongh-106217: Truncate the issue body size of `new-bugs-announce-notifier` (python#106423)
  pythongh-61215: Rename `wait_until_any_call` to `wait_until_any_call_with` (python#106414)
  pythongh-106162: array: suppress warning in test_array (python#106404)
  pythongh-106320: Remove _PyInterpreterState_HasFeature() (python#106425)
  pythonGH-106360: Support very basic superblock introspection (python#106422)
  pythongh-106406: Fix _Py_IsInterpreterFinalizing() in _winapi.c (python#106408)
  pythongh-106396: Special-case empty format spec to gen empty JoinedStr node (python#106401)
  pythongh-106368: Add tests for permutation helpers in Argument Clinic (python#106407)
  pythonGH-106008: Fix refleak when peepholing `None` comparisons (python#106367)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@lysnikolaou @miss-islington @bedevere-bot @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.