GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-106446: Fix failed doctest in stdtypes by CharlieZhao95 · Pull Request #106447 · python/cpython

Conversation

CharlieZhao95 commented Jul 5, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Fix failed doctest in stdtypes.

Issue: Doctest fails in stdtypes.rst #106446

📚 Documentation preview 📚: https://cpython-previews--106447.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Fix broken doctest in int<->str len limitation

aa58071

bedevere-bot added awaiting review docs

Documentation in the Doc dir

skip news labels

Jul 5, 2023

bedevere-bot mentioned this pull request

Jul 5, 2023

Doctest fails in stdtypes.rst #106446

Closed

terryjreedy requested changes

Jul 6, 2023

View reviewed changes

terryjreedy left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More of the doctests definitely need changes, regardless of CI issues. See issue comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot removed the awaiting review label

Jul 6, 2023

bedevere-bot commented Jul 6, 2023

Copy link

Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added the awaiting changes label

Jul 6, 2023

CharlieZhao95 commented Jul 6, 2023

Copy link

Copy Markdown

Contributor Author

More of the doctests definitely need changes, regardless of CI issues. See issue comment.

Should I put all fixes in one PR? These changes may need to be backported to different Python versions :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

terryjreedy commented Jul 9, 2023

Copy link

Copy Markdown

Member

That is why I checked the output back to 3.11. I believe everything was same back to 3.11. So 'yes'.

CharlieZhao95 reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CharlieZhao95 added 8 commits

July 10, 2023 14:19


          fix toreadonly doctest

cf8bd36


          add doctest option for address in memoryview

351b017


          fix exception doctest in cast

6b6796c


          fix set-like objects doctest

bc978eb


          fix dict[str][str]

cf5b0d4


          fix int.__subclasses__() doctest

b13122e


          fix union object doctest

e8c496a


          improve doctest

a73c1e7

CharlieZhao95 changed the title ~~gh-106446: Fix failed doctest in Integer string conversion length limitation~~ gh-106446: Fix failed doctest in stdtypes

Jul 11, 2023

CharlieZhao95 requested a review from terryjreedy

July 13, 2023 02:54


          Add byte length disclaimer

6fc53f1

terryjreedy approved these changes

Jul 13, 2023

View reviewed changes

terryjreedy left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the additions. They look good. I am not going to touch the address issue now.
I added "Note that all byte lengths may depend on the operating system." so that readers will not be puzzled if they run those examples, or doctest them, on Windows. I am ready to merge once you approve the new sentence.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CharlieZhao95 reacted with thumbs up emoji

All reactions

👍 1 reaction

bedevere-bot added awaiting merge and removed awaiting changes labels

Jul 13, 2023

CharlieZhao95 commented Jul 14, 2023

Copy link

Copy Markdown

Contributor Author

Thanks. This change looks good to me, please merge :) @terryjreedy

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

terryjreedy added needs backport to 3.11

only security fixes

needs backport to 3.12

only security fixes

DO-NOT-MERGE and removed DO-NOT-MERGE labels

Jul 14, 2023

terryjreedy added DO-NOT-MERGE and removed DO-NOT-MERGE labels

Jul 14, 2023

terryjreedy merged commit 89867d2 into python:main

Jul 14, 2023

miss-islington commented Jul 14, 2023

Copy link

Copy Markdown

Contributor

Thanks @CharlieZhao95 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Jul 14, 2023

miss-islington commented Jul 14, 2023

Copy link

Copy Markdown

Contributor

Sorry, @CharlieZhao95 and @terryjreedy, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 89867d2491c0c3ef77bc237899b2f0762f43c03c 3.11

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington assigned terryjreedy

Jul 14, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 14, 2023


          pythongh-106446: Fix failed doctest in stdtypes (pythonGH-106447)

dd31871

---------
Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit 89867d2)

Co-authored-by: Charlie Zhao <[email protected]>

bedevere-bot commented Jul 14, 2023

Copy link

Copy Markdown

GH-106741 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.12 only security fixes label

Jul 14, 2023

This comment was marked as resolved.

terryjreedy added a commit to terryjreedy/cpython that referenced this pull request

Jul 14, 2023


          pythongh-106446: Fix failed doctest in stdtypes (python#106447)

87ba4cf

---------
Co-authored-by: Terry Jan Reedy <[email protected]>

(cherry picked from commit 89867d2)

terryjreedy added a commit to terryjreedy/cpython that referenced this pull request

Jul 14, 2023


          [3.11] pythongh-106446: Fix failed doctest in stdtypes (pythonGH-106447)

f1359be

---------
Co-authored-by: Terry Jan Reedy <[email protected]>.
(cherry picked from commit 89867d2)

Co-authored-by: Charlie Zhao <[email protected]>

bedevere-bot commented Jul 14, 2023

Copy link

Copy Markdown

GH-106742 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Jul 14, 2023

terryjreedy added a commit that referenced this pull request

Jul 14, 2023


          [3.12] gh-106446: Fix failed doctest in stdtypes (GH-106447) (#106741)

00eb435

(cherry picked from commit 89867d2)

Co-authored-by: Charlie Zhao <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>

terryjreedy added a commit that referenced this pull request

Jul 14, 2023


          [3.11] gh-106446: Fix failed doctest in stdtypes (GH-106447) (#106742)

(cherry picked from commit 89867d2)

Co-authored-by: Charlie Zhao <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>

kgdiem pushed a commit to kgdiem/cpython that referenced this pull request

Jul 14, 2023


          pythongh-106446: Fix failed doctest in stdtypes (python#106447)

2dd5049

---------
Co-authored-by: Terry Jan Reedy <[email protected]>

Reviewers

terryjreedy

terryjreedy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

terryjreedy

Labels

docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

CharlieZhao95 commented Jul 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

terryjreedy left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Jul 6, 2023

Uh oh!

CharlieZhao95 commented Jul 6, 2023

Uh oh!

terryjreedy commented Jul 9, 2023

Uh oh!

terryjreedy left a comment

Choose a reason for hiding this comment

Uh oh!

CharlieZhao95 commented Jul 14, 2023

Uh oh!

miss-islington commented Jul 14, 2023

Uh oh!

miss-islington commented Jul 14, 2023

Uh oh!

bedevere-bot commented Jul 14, 2023

Uh oh!

This comment was marked as resolved.

bedevere-bot commented Jul 14, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CharlieZhao95 commented Jul 5, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.