GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — shlex docs: remove outdated note by JelleZijlstra · Pull Request #106463 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Jul 5, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

As the versionchanged notice says, this note is no longer true on 3.12+.

📚 Documentation preview 📚: https://cpython-previews--106463.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
shlex docs: remove outdated note
9608052 
As the versionchanged notice says, this note is no longer true on 3.12+.
@JelleZijlstra JelleZijlstra added the needs backport to 3.12 only security fixes label Jul 5, 2023
@JelleZijlstra
JelleZijlstra requested a review from vstinner July 5, 2023 20:20
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Jul 5, 2023
vstinner
vstinner approved these changes Jul 5, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 5, 2023
@JelleZijlstra JelleZijlstra added the skip issue label Jul 5, 2023
@JelleZijlstra

JelleZijlstra commented Jul 5, 2023

Copy link
Copy Markdown
Member Author

Cross-linking #94353 where this was changed. Thanks for the review @vstinner!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra merged commit c16ea94 into python:main Jul 5, 2023
@miss-islington

miss-islington commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 5, 2023
@JelleZijlstra
JelleZijlstra deleted the shlex branch July 5, 2023 20:38
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 5, 2023
@JelleZijlstra @miss-islington
shlex docs: remove outdated note (pythonGH-106463)
c3331c2 
As the versionchanged notice says, this note is no longer true on 3.12+.
(cherry picked from commit c16ea94)

Co-authored-by: Jelle Zijlstra <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 5, 2023

Copy link
Copy Markdown

GH-106466 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 5, 2023
JelleZijlstra added a commit that referenced this pull request Jul 5, 2023
@miss-islington @JelleZijlstra
[3.12] shlex docs: remove outdated note (GH-106463) (#106466)
a49a29f 
shlex docs: remove outdated note (GH-106463)

As the versionchanged notice says, this note is no longer true on 3.12+.
(cherry picked from commit c16ea94)

Co-authored-by: Jelle Zijlstra <[email protected]>
@JelleZijlstra
JelleZijlstra restored the shlex branch September 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JelleZijlstra @miss-islington @bedevere-bot @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.