GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106503: asyncio._SelectorSocketTransport: free another cyclic reference on close(). by pteromys · Pull Request #106504 · python/cpython

Conversation

@pteromys

@pteromys pteromys commented Jul 7, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: asyncio._SelectorSocketTransport cyclic ref leak is back as ._write_ready.__self__ #106503

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pteromys
Fix asyncio._SelectorSocketTransport ref cycle 2.
6c80818
@pteromys
pteromys requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners July 7, 2023 07:23
@bedevere-bot bedevere-bot added the awaiting review label Jul 7, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 7, 2023
asyncio._SelectorSocketTransport cyclic ref leak is back as ._write_ready.__self__ #106503
Closed
@ghost

ghost commented Jul 7, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 approved these changes Jul 7, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jul 7, 2023
@kumaraditya303 kumaraditya303 added topic-asyncio needs backport to 3.12 only security fixes labels Jul 7, 2023
@kumaraditya303
kumaraditya303 merged commit 3e5ce79 into python:main Jul 7, 2023
@miss-islington

miss-islington commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

Thanks @pteromys for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 7, 2023
@bedevere-bot

bedevere-bot commented Jul 7, 2023

Copy link
Copy Markdown

GH-106514 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 7, 2023
kumaraditya303 pushed a commit that referenced this pull request Jul 7, 2023
@miss-islington @pteromys
[3.12] gh-106503: asyncio._SelectorSocketTransport: fix cyclic refere…
7e883d7 
…nce on close(). (GH-106504) (#106514)

gh-106503: asyncio._SelectorSocketTransport: fix cyclic reference on close(). (GH-106504)
(cherry picked from commit 3e5ce79)

Co-authored-by: Andrew Geng <[email protected]>
@pteromys
pteromys deleted the fix-issue-106503 branch July 7, 2023 15:57
@Tasssadar Tasssadar mentioned this pull request Dec 17, 2024
Spurious "Exception in callback None()" after upgrading to 3.12 #115514
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@pteromys @miss-islington @bedevere-bot @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.