GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-106052: Fix bug in the matching of possessive quantifiers by serhiy-storchaka · Pull Request #106515 · python/cpython

Conversation

serhiy-storchaka commented Jul 7, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

It did not work in the case of a subpattern containing backtraces.

Temporary implement possessive quantifiers as equivalent greedy qualifiers in atomic groups.

Issue: Possessive quantifier matches where an ordinary quantifier doesn't #106052

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Edgarruiz85 reacted with heart emoji

All reactions

❤️ 1 reaction

serhiy-storchaka added needs backport to 3.11

only security fixes

needs backport to 3.12 only security fixes labels

Jul 7, 2023

bedevere-bot added the awaiting core review label

Jul 7, 2023

bedevere-bot mentioned this pull request

Jul 7, 2023

Possessive quantifier matches where an ordinary quantifier doesn't #106052

Closed

serhiy-storchaka force-pushed the re-possesive-quant-nested-backtrace branch from d73d88e to 1a420c0 Compare

July 7, 2023 12:46

ferdnyc commented Jul 10, 2023

Copy link

Copy Markdown

Contributor

@serhiy-storchaka

Nit: (and not necessarily one that needs to be addressed directly) -- do you mean "backtracking", where you write "backtraces"?

serhiy-storchaka reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          pythongh-106052: Fix bug in the matching of possessive quantifiers

89bf9dc

It did not work in the case of a subpattern containing backtracking.

Temporary implement possessive quantifiers as equivalent greedy qualifiers
in atomic groups.

serhiy-storchaka force-pushed the re-possesive-quant-nested-backtrace branch from 1a420c0 to 89bf9dc Compare

July 10, 2023 08:09

serhiy-storchaka commented Jul 10, 2023

Copy link

Copy Markdown

Member Author

Thank you @ferdnyc. Fixed.

ferdnyc reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added the DO-NOT-MERGE label

Jul 10, 2023

serhiy-storchaka commented Jul 10, 2023

Copy link

Copy Markdown

Member Author

It is a last resort. It will be merged if we not find a fix for POSSESSIVE_REPEAT implementation before the next releases.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Yhg1s commented Jul 10, 2023

Copy link

Copy Markdown

Member

Since 'the next releases' for Python 3.12 is today, do you want this in for 3.12.0 beta 4, or wait for rc1?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka commented Jul 10, 2023

Copy link

Copy Markdown

Member Author

I think it can wait for rc1, but we should not miss bugfix release for 3.11.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gpshead commented Jul 26, 2023

Copy link

Copy Markdown

Member

rc1 is in a few days if you want this in before then. I don't think this is really a release blocker even if it does sound nice to fix. 3.11 users already have to deal with the bug existence even if we manage to get a fix into a patch release.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka removed the DO-NOT-MERGE label

Aug 9, 2023

serhiy-storchaka merged commit 7b6e34e into python:main

Aug 9, 2023

miss-islington commented Aug 9, 2023

Copy link

Copy Markdown

Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting core review label

Aug 9, 2023

serhiy-storchaka deleted the re-possesive-quant-nested-backtrace branch

August 9, 2023 05:48

miss-islington commented Aug 9, 2023

Copy link

Copy Markdown

Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7b6e34e5baeb4162815ffa4d943b09a58e3f6580 3.12

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington assigned serhiy-storchaka

Aug 9, 2023

miss-islington commented Aug 9, 2023

Copy link

Copy Markdown

Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7b6e34e5baeb4162815ffa4d943b09a58e3f6580 3.11

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request

Aug 9, 2023


          [3.11] pythongh-106052: Fix bug in the matching of possessive quantif…

d9686c0

…iers (pythongh-106515)

It did not work in the case of a subpattern containing backtracking.

Temporary implement possessive quantifiers as equivalent greedy qualifiers
in atomic groups..
(cherry picked from commit 7b6e34e)

Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-bot commented Aug 9, 2023

Copy link

Copy Markdown

GH-107795 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Aug 9, 2023

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request

Aug 9, 2023


          [3.12] pythongh-106052: Fix bug in the matching of possessive quantif…

bfcee6c

…iers (pythongh-106515)

It did not work in the case of a subpattern containing backtracking.

Temporary implement possessive quantifiers as equivalent greedy qualifiers
in atomic groups..
(cherry picked from commit 7b6e34e)

Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-bot commented Aug 9, 2023

Copy link

Copy Markdown

GH-107796 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.12 only security fixes label

Aug 9, 2023

serhiy-storchaka added a commit that referenced this pull request

Aug 9, 2023


          [3.11] gh-106052: Fix bug in the matching of possessive quantifiers (G…

5b76eaf

…H-106515) (GH-107795)

It did not work in the case of a subpattern containing backtracking.

Temporary implement possessive quantifiers as equivalent greedy qualifiers
in atomic groups.
(cherry picked from commit 7b6e34e)

Yhg1s pushed a commit that referenced this pull request

Aug 9, 2023


          [3.12] gh-106052: Fix bug in the matching of possessive quantifiers (G…

3bb43b7

…H-106515) (#107796)

[3.12] gh-106052: Fix bug in the matching of possessive quantifiers (gh-106515)

It did not work in the case of a subpattern containing backtracking.

Temporary implement possessive quantifiers as equivalent greedy qualifiers
in atomic groups..
(cherry picked from commit 7b6e34e)

serhiy-storchaka removed their assignment

Sep 8, 2023

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

serhiy-storchaka commented Jul 7, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ferdnyc commented Jul 10, 2023

Uh oh!

serhiy-storchaka commented Jul 10, 2023

Uh oh!

serhiy-storchaka commented Jul 10, 2023

Uh oh!

Yhg1s commented Jul 10, 2023

Uh oh!

serhiy-storchaka commented Jul 10, 2023

Uh oh!

gpshead commented Jul 26, 2023

Uh oh!

miss-islington commented Aug 9, 2023

Uh oh!

miss-islington commented Aug 9, 2023

Uh oh!

miss-islington commented Aug 9, 2023

Uh oh!

bedevere-bot commented Aug 9, 2023

Uh oh!

bedevere-bot commented Aug 9, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

serhiy-storchaka commented Jul 7, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.