GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106531: Remove importlib.resources._legacy by jaraco · Pull Request #106532 · python/cpython

Conversation

@jaraco

@jaraco jaraco commented Jul 7, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Syncs with importlib_resources 6.0.

  • Issue: Refresh importlib.resources #106531

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
asottile reacted with thumbs down emoji
All reactions
  • 👎 1 reaction
@jaraco
pythongh-106531: Remove importlib.resources._legacy
a1bac45 
Syncs with importlib_resources 6.0.
@jaraco
jaraco requested review from FFY00 and warsaw as code owners July 7, 2023 20:28
@bedevere-bot bedevere-bot added the awaiting core review label Jul 7, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 7, 2023
Refresh importlib.resources #106531
Closed
@jaraco
Remove documentation for removed functionality.
7de5d88
@jaraco
jaraco requested review from brettcannon, ericsnowcurrently and ncoghlan as code owners July 7, 2023 20:37
@jaraco jaraco mentioned this pull request Jul 7, 2023
Deprecate legacy API in favor of traversable API (files) python/importlib_resources#80
Closed
8 tasks done
@brettcannon
brettcannon removed their request for review July 7, 2023 21:25
@jaraco

jaraco commented Jul 14, 2023

Copy link
Copy Markdown
Member Author

I'm going to proceed with the merge to give as much visibility to the change as possible, but happy to revisit if needed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco
jaraco merged commit 243fdcb into python:main Jul 14, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 14, 2023
@jaraco
jaraco deleted the debt/106531-importlib-resources-6 branch July 14, 2023 17:38
tacaswell added a commit to tacaswell/meson that referenced this pull request Jul 16, 2023
@tacaswell
FIX: account for removals in py313 in importlib
0b2dca1 
243fdcb40ebeb177ce723911c1f7fad8a1fdf6cb /
python/cpython#106532 removes functions deprecated in
py311.
@tacaswell tacaswell mentioned this pull request Jul 16, 2023
FIX: account for removals in py313 in importlib mesonbuild/meson#11998
Closed
@hugovk hugovk mentioned this pull request Oct 25, 2023
What's new in Python 3.13: move importlib.resources removals under the Removed section #111301
Closed
@asottile asottile mentioned this pull request Oct 28, 2023
python3.9+ pre-commit/pre-commit#3042
Merged
@CAM-Gerlach

CAM-Gerlach commented Nov 23, 2023

Copy link
Copy Markdown
Member

I realize this is somewhat late to the party, but is there any chance we can revert this for one release, so tools like pre-commit don't have to drop compatibility with Python 3.8 prior to it being EOL to support Python 3.13 before release (see, e.g., pre-commit/pre-commit#3042 , or else have to include a bunch of kludgy compatibility code for one Python release as in mesonbuild/meson#11998 .
joshsleeper, sanders41, mh21, and encukou reacted with thumbs up emoji tacaswell reacted with thumbs down emoji
All reactions
  • 👍 4 reactions
  • 👎 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tacaswell added a commit to tacaswell/meson that referenced this pull request Mar 13, 2024
@tacaswell
FIX: account for removals in py313 in importlib
4f7260c 
243fdcb40ebeb177ce723911c1f7fad8a1fdf6cb /
python/cpython#106532 removes functions deprecated in
py311.
@jaraco

jaraco commented Mar 20, 2024

Copy link
Copy Markdown
Member Author

I realize this is somewhat late to the party, but is there any chance we can revert this for one release, so tools like pre-commit don't have to drop compatibility with Python 3.8 prior to it being EOL to support Python 3.13 before release (see, e.g., pre-commit/pre-commit#3042 , or else have to include a bunch of kludgy compatibility code for one Python release as in mesonbuild/meson#11998 .

Sorry I missed this message earlier. It's been a rough winter season for me. Huge thanks to encukou for addressing this request in #116608.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz mentioned this pull request Sep 26, 2025
Remove deprecation notes for non-deprecated importlib.resources functions #139344
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently
@ncoghlan ncoghlan Awaiting requested review from ncoghlan

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@jaraco @CAM-Gerlach @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.