GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-106368: Increase Argument Clinic test coverage by erlend-aasland · Pull Request #106728 · python/cpython

Conversation

erlend-aasland commented Jul 13, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

improve output_parameter() coverage
improve coverage for Function.kind

Issue: Increase Argument Clinic test coverage #106368

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-106368: Argument Clinic: Increase coverage for output_parame…

46aa6d3

…ters()

erlend-aasland requested a review from AlexWaygood as a code owner

July 13, 2023 21:06

erlend-aasland added the skip news label

Jul 13, 2023

bedevere-bot added the awaiting core review label

Jul 13, 2023

bedevere-bot mentioned this pull request

Jul 4, 2023

Increase Argument Clinic test coverage #106368

Closed

erlend-aasland added needs backport to 3.11

only security fixes

needs backport to 3.12 only security fixes labels

Jul 13, 2023

AlexWaygood commented Jul 13, 2023

Copy link

Copy Markdown

Member

I'm probably not the best reviewer for this one, but this all looks reasonable!

erlend-aasland reacted with hooray emoji

All reactions

🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Pull in main

1db05ba

erlend-aasland commented Jul 13, 2023

Copy link

Copy Markdown

Contributor Author

I'm probably not the best reviewer for this one, but this all looks reasonable!

Thanks! I'll expand this PR so we've got better coverage for your FunctionKind PR.

AlexWaygood reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Expand with coverage for function kind branches

4ffd778

erlend-aasland changed the title ~~gh-106368: Argument Clinic: Increase coverage for output_parameters()~~ gh-106368: Increase Argument Clinic test coverage

Jul 13, 2023

erlend-aasland commented Jul 13, 2023

Copy link

Copy Markdown

Contributor Author

With this, we're up to approx. 86% test coverage.

AlexWaygood reacted with rocket emoji

All reactions

🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland enabled auto-merge (squash)

July 13, 2023 22:17

erlend-aasland merged commit ec45c51 into python:main

Jul 13, 2023

miss-islington commented Jul 13, 2023

Copy link

Copy Markdown

Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting core review label

Jul 13, 2023

miss-islington commented Jul 13, 2023

Copy link

Copy Markdown

Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ec45c513d389510930a62631a21a1dbb3f3aabb7 3.11

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington assigned erlend-aasland

Jul 13, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 13, 2023


          pythongh-106368: Increase Argument Clinic test coverage (pythonGH-106728

604c2ce

)

- improve output_parameter() coverage
- improve coverage for Function.kind
(cherry picked from commit ec45c51)

Co-authored-by: Erlend E. Aasland <[email protected]>

bedevere-bot commented Jul 13, 2023

Copy link

Copy Markdown

GH-106730 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.12 only security fixes label

Jul 13, 2023

erlend-aasland deleted the clinic/coverage-defining-class-alt branch

July 13, 2023 22:19

bedevere-bot commented Jul 13, 2023

Copy link

Copy Markdown

GH-106731 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Jul 13, 2023

erlend-aasland added a commit that referenced this pull request

Jul 13, 2023


          [3.12] gh-106368: Increase Argument Clinic test coverage (GH-106728) (#…

6a1a660

…106730)

- improve output_parameter() coverage
- improve coverage for Function.kind
(cherry picked from commit ec45c51)

Co-authored-by: Erlend E. Aasland <[email protected]>

This comment was marked as off-topic.

erlend-aasland added a commit that referenced this pull request

Jul 13, 2023


          [3.11] gh-106368: Increase Argument Clinic test coverage (#106728) (#…

d22224a

…106731)

- improve output_parameter() coverage
- improve coverage for Function.kind

(cherry picked from commit ec45c51)

Co-authored-by: Erlend E. Aasland <[email protected]>

* Fix merge

This comment was marked as off-topic.

kgdiem pushed a commit to kgdiem/cpython that referenced this pull request

Jul 14, 2023


          pythongh-106368: Increase Argument Clinic test coverage (python#106728)

9acddfa

- improve output_parameter() coverage
- improve coverage for Function.kind

Reviewers

AlexWaygood

Awaiting requested review from AlexWaygood

Uh oh!

There was an error while loading. Please reload this page.

Assignees

erlend-aasland

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

erlend-aasland commented Jul 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlexWaygood commented Jul 13, 2023

Uh oh!

erlend-aasland commented Jul 13, 2023

Uh oh!

erlend-aasland commented Jul 13, 2023

Uh oh!

miss-islington commented Jul 13, 2023

Uh oh!

miss-islington commented Jul 13, 2023

Uh oh!

bedevere-bot commented Jul 13, 2023

Uh oh!

bedevere-bot commented Jul 13, 2023

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

erlend-aasland commented Jul 13, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.