GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-106669: Revert "gh-102988: Detect email address parsing errors ... (#105127)" by gpshead · Pull Request #106733 · python/cpython

Conversation

gpshead commented Jul 14, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

gh-106669: Revert "gh-102988: Detect email address parsing errors and return empty tuple to indicate the parsing error (old API) (#105127)"

This reverts commit 18dfbd0 and adds the regression test suggested in the issue.

See #106669.

📚 Documentation preview 📚: https://cpython-previews--106733.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

gpshead added 2 commits

July 13, 2023 17:42


          pythongh-106669: Revert "pythongh-102988: Detect email address parsin…

362793e

…g errors and return empty tuple to indicate the parsing error (old API) (python#105127)"

This reverts commit 18dfbd0.

See python#106669.


          Keep a news entry. Describe the revert and bug.

c8f5af2

gpshead added type-bug

An unexpected behavior, bug, or error

needs backport to 3.12 only security fixes labels

Jul 14, 2023

bedevere-bot mentioned this pull request

Jul 14, 2023

email.utils.getaddresses() rejects email addresses with "," in name #106669

Closed

gpshead added 2 commits

July 13, 2023 17:52


          Add the regression test from the issue.

41cf0e5


          reword news.

2ec9cc6

gpshead marked this pull request as ready for review

July 14, 2023 00:55

gpshead requested a review from a team as a code owner

July 14, 2023 00:55

bedevere-bot added the awaiting core review label

Jul 14, 2023

gpshead self-assigned this

Jul 14, 2023

gpshead requested a review from Yhg1s

July 14, 2023 00:56

gpshead added the release-blocker label

Jul 14, 2023

felixxm mentioned this pull request

Jul 17, 2023

Refs #34118 -- Improved sanitize_address() error message for tuple with empty strings. django/django#17079

Merged

gpshead merged commit a31dea1 into python:main

Jul 21, 2023

miss-islington commented Jul 21, 2023

Copy link

Copy Markdown

Contributor

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting core review label

Jul 21, 2023

miss-islington commented Jul 21, 2023

Copy link

Copy Markdown

Contributor

Sorry, @gpshead, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a31dea1feb61793e48fa9aa5014f358352205c1d 3.12

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gpshead deleted the gh-106669 branch

July 21, 2023 03:30

gpshead added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels

Jul 21, 2023

miss-islington commented Jul 21, 2023

Copy link

Copy Markdown

Contributor

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington commented Jul 21, 2023

Copy link

Copy Markdown

Contributor

Sorry @gpshead, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker a31dea1feb61793e48fa9aa5014f358352205c1d 3.12

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gpshead added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels

Jul 21, 2023

miss-islington commented Jul 21, 2023

Copy link

Copy Markdown

Contributor

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington commented Jul 21, 2023

Copy link

Copy Markdown

Contributor

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gpshead added a commit to gpshead/cpython that referenced this pull request

Jul 21, 2023


          [3.12] pythongh-106669: Revert "pythongh-102988: Detect email address…

4288c62

… parsing errors ... (pythonGH-105127)" (pythonGH-106733)

This reverts commit 18dfbd0.
Adds a regression test from the issue.

See python#106669..
(cherry picked from commit a31dea1)

Co-authored-by: Gregory P. Smith <[email protected]>

bedevere-bot commented Jul 21, 2023

Copy link

Copy Markdown

GH-106941 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.12 only security fixes label

Jul 21, 2023

gpshead added a commit that referenced this pull request

Jul 21, 2023


          [3.12] gh-106669: Revert "gh-102988: Detect email address parsing err…

656f624

…ors ... (GH-105127)" (GH-106733) (#106941)

This reverts commit 18dfbd0.
Adds a regression test from the issue.

See #106669..
(cherry picked from commit a31dea1)

gpshead mentioned this pull request

Dec 14, 2023

[CVE-2023-27043] gh-102988: Reject malformed addresses in email.parseaddr() #111116

Merged

smoser mentioned this pull request

Feb 23, 2024

python-3.11 - cherry pick upstream patch for CVE-2023-27043 wolfi-dev/os#13586

Merged

Reviewers

Yhg1s

Awaiting requested review from Yhg1s

Uh oh!

There was an error while loading. Please reload this page.

Assignees

gpshead

Labels

release-blocker type-bug

An unexpected behavior, bug, or error

Projects

Release and Deferred blockers 🚫

Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

gpshead commented Jul 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miss-islington commented Jul 21, 2023

Uh oh!

miss-islington commented Jul 21, 2023

Uh oh!

miss-islington commented Jul 21, 2023

Uh oh!

miss-islington commented Jul 21, 2023

Uh oh!

miss-islington commented Jul 21, 2023

Uh oh!

miss-islington commented Jul 21, 2023

Uh oh!

bedevere-bot commented Jul 21, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gpshead commented Jul 14, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.