GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104050: Argument Clinic: Annotate BlockParser by erlend-aasland · Pull Request #106750 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jul 14, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Add type annotations to clinic.py #104050

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
erlend-aasland added 2 commits July 14, 2023 21:25
@erlend-aasland
Annotate BlockParser
0f5317b
@erlend-aasland
Fix warnings
019edbf
@erlend-aasland
erlend-aasland requested a review from AlexWaygood as a code owner July 14, 2023 19:36
@erlend-aasland erlend-aasland added the skip news label Jul 14, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jul 14, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 14, 2023
Add type annotations to clinic.py #104050
Closed
erlend-aasland added 2 commits July 14, 2023 21:40
@erlend-aasland
Better type hint for the regex
0507ebb
@erlend-aasland
Annotate __iter__
e61d231
erlend-aasland
erlend-aasland commented Jul 14, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland commented Jul 14, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Jul 14, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

FYI, I'll add more tests for this class before landing. See: #106759
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
Address review
924f2cf
AlexWaygood
AlexWaygood approved these changes Jul 14, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 14, 2023
@erlend-aasland
Merge branch 'main' into clinic/annotate-block-parser
7251329
@erlend-aasland
erlend-aasland enabled auto-merge (squash) July 15, 2023 09:29
@erlend-aasland
erlend-aasland merged commit bbf6297 into python:main Jul 15, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 15, 2023
@erlend-aasland
erlend-aasland deleted the clinic/annotate-block-parser branch August 22, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja left review comments
@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @hauntsaninja @AlexWaygood @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.