GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106368: Increase Argument Clinic BlockParser test coverage by erlend-aasland · Pull Request #106759 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jul 14, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Increase Argument Clinic test coverage #106368

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-106368: Increase Argument Clinic BlockParser test coverage
1611170
@erlend-aasland
erlend-aasland requested a review from AlexWaygood as a code owner July 14, 2023 21:48
@erlend-aasland erlend-aasland added skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 14, 2023
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jul 14, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 14, 2023
Increase Argument Clinic test coverage #106368
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jul 14, 2023
gh-104050: Argument Clinic: Annotate BlockParser #106750
Merged
@erlend-aasland
erlend-aasland requested a review from sobolevn July 14, 2023 22:30
sobolevn
sobolevn reviewed Jul 15, 2023
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland added 3 commits July 15, 2023 10:28
@erlend-aasland
Pull in main
83f5dc3
@erlend-aasland
Address Nikita's review:
c7caf05 
Let expect_failure() dedent and strip input string
@erlend-aasland
Address Nikita's review:
8173cd1 
Assert stuff in test_parse_with_body_prefix()
@erlend-aasland
erlend-aasland requested a review from sobolevn July 15, 2023 08:44
sobolevn
sobolevn approved these changes Jul 15, 2023
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@erlend-aasland
erlend-aasland merged commit 2d7d1aa into python:main Jul 15, 2023
@miss-islington

miss-islington commented Jul 15, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 15, 2023
@erlend-aasland
erlend-aasland deleted the clinic/buffer-stuff-coverage branch July 15, 2023 09:29
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 15, 2023
@erlend-aasland @miss-islington
pythongh-106368: Increase Argument Clinic BlockParser test coverage (p…
c067013 
…ythonGH-106759)

(cherry picked from commit 2d7d1aa)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 15, 2023

Copy link
Copy Markdown

GH-106769 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 15, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 15, 2023
@erlend-aasland @miss-islington
pythongh-106368: Increase Argument Clinic BlockParser test coverage (p…
90cd2e2 
…ythonGH-106759)

(cherry picked from commit 2d7d1aa)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 15, 2023

Copy link
Copy Markdown

GH-106770 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 15, 2023
@erlend-aasland

erlend-aasland commented Jul 15, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the review, Nikita!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland added a commit that referenced this pull request Jul 15, 2023
@miss-islington @erlend-aasland
[3.11] gh-106368: Increase Argument Clinic BlockParser test coverage (G…
b132b77 
…H-106759) (#106770)

(cherry picked from commit 2d7d1aa)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request Jul 15, 2023
@miss-islington @erlend-aasland
[3.12] gh-106368: Increase Argument Clinic BlockParser test coverage (G…
1fe8412 
…H-106759) (#106769)

(cherry picked from commit 2d7d1aa)

Co-authored-by: Erlend E. Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @miss-islington @bedevere-bot @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.