GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-86493: Fix possible leaks in modules initialization: _curses_panel, _decimal, posix, xxsubtype by serhiy-storchaka · Pull Request #106767 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 15, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Use PyModule_AddObjectRef(...) instead of PyModule_AddObject(..., Py_NewRef(...)).

  • Issue: C API: Add PyModule_Add() function #86493

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-86493: Fix possible leaks in modules initialization: _curses…
ea5afe7 
…_panel, _decimal, posix, xxsubtype
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 15, 2023
@serhiy-storchaka
serhiy-storchaka requested a review from vstinner July 15, 2023 06:12
@serhiy-storchaka
serhiy-storchaka requested a review from rhettinger as a code owner July 15, 2023 06:12
@bedevere-bot bedevere-bot added the awaiting core review label Jul 15, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 15, 2023
C API: Add PyModule_Add() function #86493
Closed
@rhettinger
rhettinger removed their request for review July 15, 2023 20:33
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jul 17, 2023
bpo-42327: Add PyModule_Add() (smaller). #23443
Merged
@serhiy-storchaka serhiy-storchaka added the skip news label Jul 18, 2023
@serhiy-storchaka
serhiy-storchaka merged commit 7454923 into python:main Jul 18, 2023
@miss-islington

miss-islington commented Jul 18, 2023

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 18, 2023
@miss-islington

miss-islington commented Jul 18, 2023

Copy link
Copy Markdown
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 745492355b94d109e47827e5865846f25ae42d26 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned serhiy-storchaka Jul 18, 2023
@miss-islington

miss-islington commented Jul 18, 2023

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 745492355b94d109e47827e5865846f25ae42d26 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka deleted the pymodule-add4a branch July 18, 2023 06:00
@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Jul 18, 2023
@miss-islington

miss-islington commented Jul 18, 2023

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 18, 2023

Copy link
Copy Markdown
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 745492355b94d109e47827e5865846f25ae42d26 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Jul 18, 2023
@miss-islington

miss-islington commented Jul 18, 2023

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 18, 2023

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 745492355b94d109e47827e5865846f25ae42d26 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 18, 2023
@serhiy-storchaka
[3.12] pythongh-86493: Fix possible leaks in modules initialization: …
d158e97 
…_curses_panel, _decimal, posix, xxsubtype (pythonGH-106767).

(cherry picked from commit 7454923)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 18, 2023

Copy link
Copy Markdown

GH-106849 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 18, 2023
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.11 only security fixes label Jul 18, 2023
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 18, 2023
serhiy-storchaka added a commit that referenced this pull request Jul 18, 2023
@serhiy-storchaka
[3.12] gh-86493: Fix possible leaks in modules initialization: _curse…
970cb8e 
…s_panel, _decimal, posix, xxsubtype (GH-106767) (#106849)

(cherry picked from commit 7454923)
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 18, 2023
@serhiy-storchaka
[3.11] [3.12] pythongh-86493: Fix possible leaks in modules initializ…
b0b65c1 
…ation: _curses_panel, _decimal, posix, xxsubtype (pythonGH-106767) (pythonGH-106849)

(cherry picked from commit 7454923).
(cherry picked from commit 970cb8e)

Co-authored-by: Serhiy Storchaka <[email protected]>
@vstinner

vstinner commented Jul 18, 2023

Copy link
Copy Markdown
Member

It's so hard to get PyInit code right :-( Thanks for the fix.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka added a commit that referenced this pull request Jul 18, 2023
@serhiy-storchaka
[3.11] gh-86493: Fix possible leaks in modules initialization: _curse…
3841af4 
…s_panel, _decimal, posix, xxsubtype (GH-106767) (GH-106849) (GH-106851)

(cherry picked from commit 7454923)
(cherry picked from commit 970cb8e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @miss-islington @bedevere-bot @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.