GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106368: Increase Argument Clinic test coverage for cpp.Monitor by erlend-aasland · Pull Request #106833 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jul 17, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Alternative to gh-106813

  • Issue: Increase Argument Clinic test coverage #106368

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-106368: Add functional tests for Tools/clinic/cpp.py
bd9ec0e
@erlend-aasland
erlend-aasland requested a review from AlexWaygood as a code owner July 17, 2023 19:44
@bedevere-bot bedevere-bot added the awaiting core review label Jul 17, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 17, 2023
Increase Argument Clinic test coverage #106368
Closed
@erlend-aasland
erlend-aasland requested a review from sobolevn July 17, 2023 19:44
@erlend-aasland erlend-aasland changed the title gh-106368: Add functional tests for Tools/clinic/cpp.py gh-106368: Increase Argument Clinic test coverage for cpp.Monitor Jul 17, 2023
@sobolevn sobolevn added the skip news label Jul 17, 2023
sobolevn
sobolevn approved these changes Jul 17, 2023
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/clinic.test.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Jul 17, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the review!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland added 2 commits July 17, 2023 22:24
@erlend-aasland
Pull in main
0aadd9e
@erlend-aasland
Add clarifying comment
32c2510
@erlend-aasland
erlend-aasland enabled auto-merge (squash) July 17, 2023 20:26
@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 17, 2023
@erlend-aasland
erlend-aasland merged commit 22379c6 into python:main Jul 17, 2023
@miss-islington

miss-islington commented Jul 17, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 17, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2023
@erlend-aasland @miss-islington
pythongh-106368: Increase Argument Clinic test coverage for cpp.Monit…
a17c88c 
…or (pythonGH-106833)

(cherry picked from commit 22379c6)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 17, 2023

Copy link
Copy Markdown

GH-106838 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 17, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2023
@erlend-aasland @miss-islington
pythongh-106368: Increase Argument Clinic test coverage for cpp.Monit…
4a7ec0e 
…or (pythonGH-106833)

(cherry picked from commit 22379c6)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 17, 2023

Copy link
Copy Markdown

GH-106839 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 17, 2023
@erlend-aasland
erlend-aasland deleted the clinic/cpp-test-coverage-alt branch July 17, 2023 20:58
erlend-aasland added a commit that referenced this pull request Jul 17, 2023
@miss-islington @erlend-aasland
[3.12] gh-106368: Increase Argument Clinic test coverage for cpp.Moni…
941ac1e 
…tor (GH-106833) (#106838)

(cherry picked from commit 22379c6)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request Jul 17, 2023
@miss-islington @erlend-aasland
[3.11] gh-106368: Increase Argument Clinic test coverage for cpp.Moni…
a7acc5c 
…tor (GH-106833) (#106839)

(cherry picked from commit 22379c6)

Co-authored-by: Erlend E. Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @miss-islington @bedevere-bot @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.