GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-86493: Fix possible leaks in some modules initialization (GH-106768) by serhiy-storchaka · Pull Request #106855 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 18, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fix _ssl, _stat, _testinternalcapi, _threadmodule, cmath, math, posix, time.

(cherry picked from commit 3e65bae)

  • Issue: C API: Add PyModule_Add() function #86493

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
[3.12] pythongh-86493: Fix possible leaks in some modules initializat…
e163ec1 
…ion (pythonGH-106768)

Fix _ssl, _stat, _testinternalcapi, _threadmodule, cmath, math, posix, time..
(cherry picked from commit 3e65bae)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka
serhiy-storchaka requested review from abalkin and pganssle as code owners July 18, 2023 09:51
@bedevere-bot bedevere-bot added the awaiting core review label Jul 18, 2023
This was referenced Jul 18, 2023
C API: Add PyModule_Add() function #86493
Closed
gh-86493: Fix possible leaks in some modules initialization #106768
Merged
@bedevere-bot bedevere-bot added the skip news label Jul 18, 2023
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.11 only security fixes label Jul 18, 2023
@serhiy-storchaka
serhiy-storchaka merged commit a423ddb into python:3.12 Jul 18, 2023
@miss-islington

miss-islington commented Jul 18, 2023

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 18, 2023
@miss-islington

miss-islington commented Jul 18, 2023

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a423ddbdeada8a2fd8657453b9e9f58ba0dd921d 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned serhiy-storchaka Jul 18, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 18, 2023
@serhiy-storchaka
[3.11] [3.12] pythongh-86493: Fix possible leaks in some modules init…
708a1b6 
…ialization (pythonGH-106768) (pythonGH-106855)

Fix _ssl, _stat, _testinternalcapi, _threadmodule, cmath, math, posix, time.
(cherry picked from commit 3e65bae).
(cherry picked from commit a423ddb)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 18, 2023

Copy link
Copy Markdown

GH-106863 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 18, 2023
@bedevere-bot

bedevere-bot commented Jul 18, 2023

Copy link
Copy Markdown

GH-106863 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka added a commit that referenced this pull request Jul 19, 2023
@serhiy-storchaka
[3.11] gh-86493: Fix possible leaks in some modules initialization (G…
fced79f 
…H-106768) (GH-106855) (GH-106863)

[3.11] [3.12] gh-86493: Fix possible leaks in some modules initialization (GH-106768) (GH-106855)

Fix _ssl, _stat, _testinternalcapi, _threadmodule, cmath, math, posix, time.
(cherry picked from commit 3e65bae).
(cherry picked from commit a423ddb)
@serhiy-storchaka
serhiy-storchaka deleted the backport-3e65bae-3.12 branch July 25, 2023 09:47
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.