GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-47146: Fix reference counting in _testcapi.structmember initializer by serhiy-storchaka · Pull Request #106862 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 18, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: PyMemberDef missing in limited API / Deprecate structmember.h #47146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-47146: Fix reference counting in _testcapi.structmember init…
2f6a9a1 
…ializer
@serhiy-storchaka serhiy-storchaka added skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 18, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jul 18, 2023
@bedevere-bot bedevere-bot mentioned this pull request Nov 22, 2022
PyMemberDef missing in limited API / Deprecate structmember.h #47146
Closed
@serhiy-storchaka
serhiy-storchaka requested review from encukou and vstinner July 18, 2023 12:25
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jul 18, 2023
gh-47146: Soft-deprecate structmember.h, expose its contents via Python.h #99014
Merged
erlend-aasland
erlend-aasland approved these changes Jul 21, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 21, 2023
@serhiy-storchaka
serhiy-storchaka merged commit 8d397ee into python:main Jul 21, 2023
@miss-islington

miss-islington commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 21, 2023
@serhiy-storchaka
serhiy-storchaka deleted the _PyTestCapi_Init_Structmember branch July 21, 2023 09:30
@miss-islington

miss-islington commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8d397ee8259fa0f81598a452438fc335267ca260 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned serhiy-storchaka Jul 21, 2023
@bedevere-bot

bedevere-bot commented Jul 21, 2023

Copy link
Copy Markdown

GH-106953 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 21, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 21, 2023
@serhiy-storchaka @miss-islington
pythongh-47146: Fix reference counting in _testcapi.structmember init…
54c2598 
…ializer (pythonGH-106862)

(cherry picked from commit 8d397ee)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.11 only security fixes label Jul 21, 2023
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 21, 2023
serhiy-storchaka added a commit that referenced this pull request Jul 21, 2023
@miss-islington @serhiy-storchaka
[3.12] gh-47146: Fix reference counting in _testcapi.structmember ini…
4be0f15 
…tializer (GH-106862) (GH-106953)

(cherry picked from commit 8d397ee)

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@vstinner vstinner Awaiting requested review from vstinner
@encukou encukou Awaiting requested review from encukou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @miss-islington @bedevere-bot @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.