GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104050: Argument Clinic: Annotate the BufferSeries class by erlend-aasland · Pull Request #106935 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jul 20, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Add type annotations to clinic.py #104050

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
erlend-aasland added 2 commits July 21, 2023 00:35
@erlend-aasland
pythongh-104050: Argument Clinic: Annotate BufferSeries
07d41a0
@erlend-aasland
Fix bug in clear() method
1dadf8f 
_TextAccumulator has no '_text' attribute; it has 'text'
@erlend-aasland
erlend-aasland requested a review from AlexWaygood as a code owner July 20, 2023 22:36
@erlend-aasland erlend-aasland added the skip news label Jul 20, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jul 20, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 20, 2023
Add type annotations to clinic.py #104050
Closed
AlexWaygood
AlexWaygood reviewed Jul 20, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland changed the title gh-104050: Argument Clinic: Annotate BufferSeries class gh-104050: Argument Clinic: Annotate the BufferSeries class Jul 20, 2023
serhiy-storchaka
serhiy-storchaka approved these changes Jul 21, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Outdated
Comment on lines +1973 to +1976
def __getitem__(
self,
i: int
) -> _TextAccumulator:

@serhiy-storchaka serhiy-storchaka Jul 21, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not write it in one line? It is still pretty short.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@erlend-aasland erlend-aasland Jul 21, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure; I have not yet developed a preference when it comes to annotation style :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@AlexWaygood AlexWaygood Jul 21, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I agree with Serhiy — I would probably put this all on one line — but I also don't really care much either way (life's too short to spend it arguing over code formatting preferences 😄)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction

@erlend-aasland erlend-aasland Jul 21, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(life's too short to spend it arguing over code formatting preferences 😄)

No, it isn't! 😆

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood reacted with laugh emoji
All reactions
  • 😄 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 21, 2023
@erlend-aasland erlend-aasland mentioned this pull request Jul 21, 2023
Argument Clinic 'destination <name> clear' is broken #106970
Closed
erlend-aasland added 2 commits July 21, 2023 23:58
@erlend-aasland
Pull in main
a62050c
@erlend-aasland
Address review: style nit
c21858b
@erlend-aasland

erlend-aasland commented Jul 21, 2023

Copy link
Copy Markdown
Contributor Author

On hold until #106972 has landed.
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
Merge branch 'main' into clinic/annotate-buffer-series
c1d46c7
AlexWaygood
AlexWaygood approved these changes Jul 22, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@erlend-aasland
erlend-aasland merged commit c5adf26 into python:main Jul 22, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 22, 2023
@erlend-aasland

erlend-aasland commented Jul 22, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the reviews!
AlexWaygood reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland deleted the clinic/annotate-buffer-series branch July 22, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @serhiy-storchaka @AlexWaygood @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.