GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Argument Clinic 'destination <name> clear' is broken · Issue #106970 · python/cpython

Argument Clinic 'destination <name> clear' is broken #106970

New issue
Copy link
New issue
Copy link
Closed
Closed
Argument Clinic 'destination <name> clear' is broken#106970
Copy link
Assignees
erlend-aasland
Labels
topic-argument-clinictype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

Description

@erlend-aasland
erlend-aasland
opened on Jul 21, 2023
Issue body actions

The destination <name> clear command is documented like this:

It removes all the accumulated text up to this point in the destination. (I don’t know what you’d need this for, but I thought maybe it’d be useful while someone’s experimenting.)

Clearly, the last sentence is correct, because this command contains two bugs, and nobody has ever complained:

  1. It accesses the wrong attribute when clearing the accumulators
  2. The directive parser does not return immediately after executing the clear command, so it jumps straight into "fail because we got an unknown command"

The fixes are easy, so I suggest we apply the fixes and add regressions tests. An alternative could be to remove the clear command, but I don't think we should tear out features lightly, no matter how obscure they are.

Found while working on #106935.

Linked PRs

  • gh-106970: Fix Argument Clinic 'destination <name> clear' command #106972
  • [3.12] gh-106970: Fix Argument Clinic 'destination <name> clear' command (GH-106972) #106983
  • [3.11] gh-106970: Fix Argument Clinic 'destination <name> clear' command (#106972) #107059

Activity

  1. erlend-aasland
    added
    type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
    topic-argument-clinic
    on Jul 21, 2023
  2. erlend-aasland
    self-assigned this
    on Jul 21, 2023
  3. erlend-aasland
    added a commit that references this issue on Jul 22, 2023

    gh-106970: Fix Argument Clinic 'destination <name> clear' command (#1…

    3372bcb
  4. miss-islington
    added a commit that references this issue on Jul 22, 2023

    pythongh-106970: Fix Argument Clinic 'destination <name> clear' comma…

    588f331
  5. erlend-aasland
    added 2 commits that reference this issue on Jul 22, 2023

    [3.12] gh-106970: Fix Argument Clinic 'destination <name> clear' comm…

    67748f1

    [3.11] gh-106970: Fix Argument Clinic 'destination <name> clear' comm…

    63c945a
  6. AlexWaygood commented on Jul 24, 2023

    @AlexWaygood
    AlexWaygood
    on Jul 24, 2023
    Member
    More actions

    Is this fixed now?

  7. erlend-aasland
    closed this as completedon Jul 24, 2023
  8. erlend-aasland commented on Jul 24, 2023

    @erlend-aasland
    erlend-aasland
    on Jul 24, 2023
    ContributorAuthor
    More actions

    Yep!

    Reacted by Alex Waygood
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

  • @erlend-aasland
    erlend-aasland

Labels

topic-argument-clinictype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    You are visitor 01402503 — GeezerVison does not store the pages you look up.
    Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.