GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106948: Add standard external names to nitpick_ignore by serhiy-storchaka · Pull Request #106949 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 21, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It includes standard C types, macros and variables like "size_t", "LONG_MAX" and "errno", and standard environment variables like "PATH".

  • Issue: Docs: add standard external names to nitpick_ignore #106948

📚 Documentation preview 📚: https://cpython-previews--106949.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland and hugovk reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@serhiy-storchaka
pythongh-106948: Add standard external names to nitpick_ignore
9079a34 
It includes standard C types, macros and variables like "size_t",
"LONG_MAX" and "errno", and standard environment variables like "PATH".
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 21, 2023
@serhiy-storchaka
serhiy-storchaka requested a review from erlend-aasland July 21, 2023 08:53
@bedevere-bot bedevere-bot mentioned this pull request Jul 21, 2023
Docs: add standard external names to nitpick_ignore #106948
Closed
serhiy-storchaka added 6 commits July 21, 2023 12:11
@serhiy-storchaka
REmove some !s.
1f10607
@serhiy-storchaka
Use :c:type: role.
06eec6a
@serhiy-storchaka
Reduce Doc/library/importlib.rst.
31488dc
@serhiy-storchaka
_Bool is a keyword.
dc6d2c8
@serhiy-storchaka
Merge branch 'main' into nitpick_ignore
1ce104a
@serhiy-storchaka
Reduce Doc/tools/.nitignore.
941ba8c
@serhiy-storchaka
serhiy-storchaka marked this pull request as ready for review July 22, 2023 14:32
@serhiy-storchaka
serhiy-storchaka requested a review from vsajip as a code owner July 22, 2023 14:32
@bedevere-bot bedevere-bot added the awaiting core review label Jul 22, 2023
serhiy-storchaka added 2 commits July 22, 2023 18:21
@serhiy-storchaka
Add other locale envvars.
7fe195c
@serhiy-storchaka
COLS is not an envvar.
60cfe62
erlend-aasland
erlend-aasland approved these changes Jul 22, 2023
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Why are you using :c:texpr: for _Bool?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 22, 2023
@serhiy-storchaka

serhiy-storchaka commented Jul 22, 2023

Copy link
Copy Markdown
Member Author

Why are you using :c:texpr: for _Bool?

Because it is the correct role for a type expression in C. I prepared a large patch for using :c:texpr:, but it depends on this PR. And this PR depends on #107011.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka marked this pull request as draft July 22, 2023 16:18
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 22, 2023
@serhiy-storchaka
Merge branch 'main' into nitpick_ignore
381205f
@serhiy-storchaka
serhiy-storchaka marked this pull request as ready for review July 22, 2023 17:20
@bedevere-bot bedevere-bot added the awaiting core review label Jul 22, 2023
@erlend-aasland

erlend-aasland commented Jul 22, 2023

Copy link
Copy Markdown
Contributor

I thought the T in :texpr: stood for text, not type: https://www.sphinx-doc.org/en/master/usage/restructuredtext/domains.html#inline-expressions-and-types
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Jul 22, 2023

Copy link
Copy Markdown
Contributor

Also, _Bool is a built-in C type. I don't see why it should be marked up differently from int.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
Revert :c:texpr: to :c:expr:.
ec12ccb
@serhiy-storchaka

serhiy-storchaka commented Jul 22, 2023

Copy link
Copy Markdown
Member Author

You are right. I misread the documentation. Thank you, you saved me from opening a new issue.
erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka merged commit f8b7fe2 into python:main Jul 22, 2023
@miss-islington

miss-islington commented Jul 22, 2023

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 22, 2023
@serhiy-storchaka
serhiy-storchaka deleted the nitpick_ignore branch July 22, 2023 18:35
@miss-islington

miss-islington commented Jul 22, 2023

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f8b7fe2f2647813ae8249675a80e59c117d30fe1 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned serhiy-storchaka Jul 22, 2023
@miss-islington

miss-islington commented Jul 22, 2023

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f8b7fe2f2647813ae8249675a80e59c117d30fe1 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 22, 2023
@serhiy-storchaka
[3.12] pythongh-106948: Add standard external names to nitpick_ignore (…
adb7c9b 
…pythonGH-106949)

It includes standard C types, macros and variables like "size_t",
"LONG_MAX" and "errno", and standard environment variables like "PATH"..
(cherry picked from commit f8b7fe2)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 22, 2023

Copy link
Copy Markdown

GH-107060 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 22, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 22, 2023
@serhiy-storchaka
[3.11] pythongh-106948: Add standard external names to nitpick_ignore (…
2c76f6a 
…pythonGH-106949)

It includes standard C types, macros and variables like "size_t",
"LONG_MAX" and "errno", and standard environment variables like "PATH"..
(cherry picked from commit f8b7fe2)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 22, 2023

Copy link
Copy Markdown

GH-107061 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 22, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 22, 2023
@serhiy-storchaka
[3.12] pythongh-106948: Add standard external names to nitpick_ignore (…
95e6108 
…pythonGH-106949)

It includes standard C types, macros and variables like "size_t",
"LONG_MAX" and "errno", and standard environment variables like "PATH".

(cherry picked from commit f8b7fe2)

Co-authored-by: Serhiy Storchaka <[email protected]>
ambv pushed a commit that referenced this pull request Jul 23, 2023
@serhiy-storchaka
[3.11] gh-106948: Add standard external names to nitpick_ignore (GH-1…
ec8718d 
…06949) (#107061)

It includes standard C types, macros and variables like "size_t",
"LONG_MAX" and "errno", and standard environment variables like "PATH"..
(cherry picked from commit f8b7fe2)
ambv pushed a commit that referenced this pull request Jul 23, 2023
@serhiy-storchaka
[3.12] gh-106948: Add standard external names to nitpick_ignore (GH-1…
456cf8b 
…06949) (#107060)

* [3.12] gh-106948: Add standard external names to nitpick_ignore (GH-106949)

It includes standard C types, macros and variables like "size_t",
"LONG_MAX" and "errno", and standard environment variables like "PATH".

(cherry picked from commit f8b7fe2)

Co-authored-by: Serhiy Storchaka <[email protected]>

* Delete 2023-05-31-18-37-57.gh-issue-105156.R4El5V.rst
mementum pushed a commit to mementum/cpython that referenced this pull request Jul 23, 2023
@serhiy-storchaka @mementum
pythongh-106948: Add standard external names to nitpick_ignore (pytho…
28cbc89 
…nGH-106949)

It includes standard C types, macros and variables like "size_t",
"LONG_MAX" and "errno", and standard environment variables like "PATH".
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @erlend-aasland @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.