GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106368: Increase coverage for Argument Clinic output directive by erlend-aasland · Pull Request #106979 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jul 21, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Increase Argument Clinic test coverage #106368

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-106368: Increase coverage for Argument Clinic output directive
c95cd19
@erlend-aasland
erlend-aasland requested a review from AlexWaygood as a code owner July 21, 2023 21:57
@erlend-aasland erlend-aasland added skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 21, 2023
@erlend-aasland
erlend-aasland requested a review from sobolevn July 21, 2023 21:57
@bedevere-bot bedevere-bot added the awaiting core review label Jul 21, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 21, 2023
Increase Argument Clinic test coverage #106368
Closed
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Jul 21, 2023
sobolevn
sobolevn approved these changes Jul 22, 2023
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My question is not blocking :)
Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Comment thread Lib/test/test_clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ambv
Merge branch 'main' into clinic/coverage-output-directive
264230c
@erlend-aasland

erlend-aasland commented Jul 22, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the reviews!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland enabled auto-merge (squash) July 22, 2023 09:06
@erlend-aasland
erlend-aasland merged commit ee5c01b into python:main Jul 22, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 22, 2023
@miss-islington

miss-islington commented Jul 22, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 22, 2023

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ee5c01b473eeadb007b9f330db3143e34e46038b 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned erlend-aasland Jul 22, 2023
@bedevere-bot

bedevere-bot commented Jul 22, 2023

Copy link
Copy Markdown

GH-106994 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 22, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2023
@erlend-aasland @miss-islington
pythongh-106368: Increase coverage for Argument Clinic output directi…
483c3d6 
…ve (pythonGH-106979)

(cherry picked from commit ee5c01b)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 22, 2023

Copy link
Copy Markdown

GH-107002 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 22, 2023
ambv pushed a commit to ambv/cpython that referenced this pull request Jul 22, 2023
@erlend-aasland @ambv
[3.11] pythongh-106368: Increase coverage for Argument Clinic output …
42dd5ce 
…directive (pythonGH-106979)

(cherry picked from commit ee5c01b)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request Jul 22, 2023
@miss-islington @erlend-aasland
[3.12] gh-106368: Increase coverage for Argument Clinic output direct…
76fd98a 
…ive (GH-106979) (#106994)

(cherry picked from commit ee5c01b)

Co-authored-by: Erlend E. Aasland <[email protected]>
@erlend-aasland

erlend-aasland commented Jul 22, 2023

Copy link
Copy Markdown
Contributor Author

I'll fix the backport later, unless someone beats me to it :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ambv added a commit that referenced this pull request Jul 22, 2023
@ambv @erlend-aasland
[3.11] gh-106368: Increase coverage for Argument Clinic output direct…
06f8a43 
…ive (GH-106979) (#107002)

(cherry picked from commit ee5c01b)

Co-authored-by: Erlend E. Aasland <[email protected]>
@erlend-aasland
erlend-aasland deleted the clinic/coverage-output-directive branch July 22, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv left review comments
@sobolevn sobolevn sobolevn approved these changes
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@erlend-aasland erlend-aasland

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @miss-islington @bedevere-bot @ambv @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.