GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-106970: Fix Argument Clinic 'destination <name> clear' command (GH-106972) by miss-islington · Pull Request #106983 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 22, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Add test for the 'destination clear' command,
and the 'destination' directive in general.

Fix two bugs in 'destination clear' command:

  1. The text attribute of the allocator is called 'text', not '_text'
  2. Return after processing the 'clear' command,
    instead of proceeding directly to the fail().
    (cherry picked from commit 3372bcb)

Co-authored-by: Erlend E. Aasland [email protected]

  • Issue: Argument Clinic 'destination <name> clear' is broken #106970

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland @miss-islington
pythongh-106970: Fix Argument Clinic 'destination <name> clear' comma…
588f331 
…nd (pythonGH-106972)

Add test for the 'destination <name> clear' command,
and the 'destination' directive in general.

Fix two bugs in 'destination <name> clear' command:

1. The text attribute of the allocator is called 'text', not '_text'
2. Return after processing the 'clear' command,
   instead of proceeding directly to the fail().
(cherry picked from commit 3372bcb)

Co-authored-by: Erlend E. Aasland <[email protected]>
This was referenced Jul 22, 2023
Argument Clinic 'destination <name> clear' is broken #106970
Closed
gh-106970: Fix Argument Clinic 'destination <name> clear' command #106972
Merged
@bedevere-bot bedevere-bot added the awaiting review label Jul 22, 2023
@erlend-aasland
erlend-aasland merged commit 67748f1 into python:3.12 Jul 22, 2023
@bedevere-bot bedevere-bot removed the awaiting review label Jul 22, 2023
@miss-islington
miss-islington deleted the backport-3372bcb-3.12 branch July 22, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.