GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-107017: Analolgy to Pascal and C replaced. by TommyUnreal · Pull Request #107025 · python/cpython

Conversation

@TommyUnreal

@TommyUnreal TommyUnreal commented Jul 22, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Knowledge of arithmetic is more accessible than knowledge of other programming languages. An analogy is, therefore, more accessible.

  • Issue: remove the assumptions from The tutorial #107017

📚 Documentation preview 📚: https://cpython-previews--107025.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TommyUnreal
Analolgy to Pascal and C replaced.
f07a19c 
Knowledge of arithmetic is more accessible than knowledge of other programming languages. An analogy is, therefore, more accessible.
@bedevere-bot bedevere-bot mentioned this pull request Jul 22, 2023
remove the assumptions from The tutorial #107017
Closed
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 22, 2023
@ghost

ghost commented Jul 22, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
evildmp
evildmp approved these changes Jul 22, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Jul 22, 2023
@TommyUnreal
Removed trailing whitespace.
1c76c37
serhiy-storchaka
serhiy-storchaka reviewed Jul 22, 2023
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In mathematics you use ·, ×, : and ÷.

* for multiplication is only used in programming.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hauntsaninja reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@evildmp

evildmp commented Jul 22, 2023

Copy link
Copy Markdown
Contributor

In mathematics you use ·, ×, : and ÷.

* for multiplication is only used in programming.

It's standard and familiar to most people who use computers - anyone who has used a spreadsheet application, for example. I think that it's also made pretty clear in the examples, which in a tutorial is much more effective than complicating a brief explanation.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hauntsaninja
hauntsaninja reviewed Jul 22, 2023
View reviewed changes

@hauntsaninja hauntsaninja left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's true that * and / have so completely won out that a) newcomers from C or Pascal don't need to be told they can be used for arithmetic, b) most people who've used computers would not find this surprising, c) / doesn't really work like C in Python 3

My wording suggestion therefore minimises length

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TommyUnreal reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread Doc/tutorial/introduction.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@TommyUnreal @hauntsaninja
Changed the wording to be more condensed.
dbbf594 
Co-authored-by: Shantanu <[email protected]>
@TommyUnreal

TommyUnreal commented Jul 23, 2023

Copy link
Copy Markdown
Contributor Author

I think it's true that * and / have so completely won out that a) newcomers from C or Pascal don't need to be told they can be used for arithmetic, b) most people who've used computers would not find this surprising, c) / doesn't really work like C in Python 3

My wording suggestion therefore minimises length

Hi! I appreciate your suggestion. I like the wording better as it holds the same information but in a more condensed format.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk approved these changes Jul 23, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 23, 2023
@hugovk
hugovk merged commit e59da0c into python:main Jul 23, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 23, 2023
@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 23, 2023
@miss-islington

miss-islington commented Jul 23, 2023

Copy link
Copy Markdown
Contributor

Thanks @TommyUnreal for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 23, 2023

Copy link
Copy Markdown
Contributor

Thanks @TommyUnreal for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jul 23, 2023

Copy link
Copy Markdown

GH-107123 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 23, 2023
@TommyUnreal @hauntsaninja @miss-islington
pythongh-107017: Analolgy to Pascal and C replaced. (pythonGH-107025)
2bfa026 
(cherry picked from commit e59da0c)

Co-authored-by: TommyUnreal <[email protected]>
Co-authored-by: Shantanu <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 23, 2023
@bedevere-bot

bedevere-bot commented Jul 23, 2023

Copy link
Copy Markdown

GH-107124 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 23, 2023
@TommyUnreal @hauntsaninja @miss-islington
pythongh-107017: Analolgy to Pascal and C replaced. (pythonGH-107025)
7baeaa3 
(cherry picked from commit e59da0c)

Co-authored-by: TommyUnreal <[email protected]>
Co-authored-by: Shantanu <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 23, 2023
hugovk added a commit that referenced this pull request Jul 23, 2023
@miss-islington @TommyUnreal
@hauntsaninja @hugovk
[3.11] gh-107017: Analolgy to Pascal and C replaced. (GH-107025) (#10…
6138ecd 
…7123)

Co-authored-by: TommyUnreal <[email protected]>
Co-authored-by: Shantanu <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
ambv pushed a commit that referenced this pull request Jul 23, 2023
@miss-islington @TommyUnreal @hauntsaninja
[3.12] gh-107017: Analolgy to Pascal and C replaced. (GH-107025) (#10…
e02ddb3 
…7124)

(cherry picked from commit e59da0c)

Co-authored-by: TommyUnreal <[email protected]>
Co-authored-by: Shantanu <[email protected]>
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 23, 2023
@TommyUnreal @hauntsaninja @jtcave
pythongh-107017: Analolgy to Pascal and C replaced. (python#107025)
610db99 
Co-authored-by: Shantanu <[email protected]>
mementum pushed a commit to mementum/cpython that referenced this pull request Jul 23, 2023
@TommyUnreal @hauntsaninja @mementum
pythongh-107017: Analolgy to Pascal and C replaced. (python#107025)
2d648af 
Co-authored-by: Shantanu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments
@hauntsaninja hauntsaninja hauntsaninja left review comments
@hugovk hugovk hugovk approved these changes
+1 more reviewer
@evildmp evildmp evildmp approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@TommyUnreal @evildmp @miss-islington @bedevere-bot @hugovk @serhiy-storchaka @hauntsaninja
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.