GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106320: Remove _Py_SwappedOp from the C API by vstinner · Pull Request #107036 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jul 22, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Move _Py_SwappedOp to the internal C API (pycore_object.h).

  • Issue: C API: Remove private C API functions (move them to the internal C API) #106320

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added skip news topic-C-API labels Jul 22, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 22, 2023
C API: Remove private C API functions (move them to the internal C API) #106320
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Jul 22, 2023
@vstinner
vstinner enabled auto-merge (squash) July 22, 2023 14:16
corona10
corona10 approved these changes Jul 22, 2023
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, if someone is using this API, they can write their utility function.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 22, 2023
@vstinner

vstinner commented Jul 22, 2023

Copy link
Copy Markdown
Member Author

lgtm, if someone is using this API, they can write their utility function.

If someone uses it, we can consider exposing a public API for that.

Or they can just copy/paste this short array in their code.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
pythongh-106320: Remove _Py_SwappedOp from the C API
3d30d79 
Move _Py_SwappedOp to the internal C API (pycore_object.h).
The symbol is still exported since it's part of the stable ABI.
@vstinner
vstinner force-pushed the remove_swapped_op branch from 136f64d to 3d30d79 Compare July 22, 2023 14:46
@vstinner

vstinner commented Jul 22, 2023

Copy link
Copy Markdown
Member Author

The symbol must still be exported since it's part of the stable ABI.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 6fbc717 into python:main Jul 22, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 22, 2023
@vstinner
vstinner deleted the remove_swapped_op branch July 22, 2023 16:21
mementum pushed a commit to mementum/cpython that referenced this pull request Jul 23, 2023
@vstinner @mementum
pythongh-106320: Remove _Py_SwappedOp from the C API (python#107036)
298bb8d 
Move _Py_SwappedOp to the internal C API (pycore_object.h).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @corona10 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.