GeezerVison is showing github.com — [3.11] gh-106970: Fix Argument Clinic 'destination <name> clear' command (#106972) by erlend-aasland · Pull Request #107059 · python/cpython
Conversation
erlend-aasland
commented
Jul 22, 2023
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Add test for the 'destination clear' command,
and the 'destination' directive in general.
Fix two bugs in 'destination clear' command:
- The text attribute of the allocator is called 'text', not '_text'
- Return after processing the 'clear' command,
instead of proceeding directly to the fail().
(cherry picked from commit 3372bcb)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…' command (python#106972)
Add test for the 'destination <name> clear' command,
and the 'destination' directive in general.
Fix two bugs in 'destination <name> clear' command:
1. The text attribute of the allocator is called 'text', not '_text'
2. Return after processing the 'clear' command,
instead of proceeding directly to the fail().
(cherry picked from commit 3372bcb)
This was referenced Jul 22, 2023
|
FTR, test_unknown_destination_command() was accidentally added in gh-107002. Originally it was a part of gh-106972, so it should have been a part of this backport as well.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.