GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106320: Move _PyMethodWrapper_Type to internal C API by vstinner · Pull Request #107064 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jul 22, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: C API: Remove private C API functions (move them to the internal C API) #106320

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-106320: Move _PyMethodWrapper_Type to internal C API
a9426db
@vstinner vstinner added the skip news label Jul 22, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jul 22, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 22, 2023
C API: Remove private C API functions (move them to the internal C API) #106320
Closed
@vstinner
vstinner enabled auto-merge (squash) July 22, 2023 20:49
@vstinner
vstinner merged commit ee15844 into python:main Jul 22, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 22, 2023
@vstinner
vstinner deleted the method_wrapper_type branch July 22, 2023 21:05
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 23, 2023
@vstinner @jtcave
pythongh-106320: Move _PyMethodWrapper_Type to internal C API (python…
5b02245 
…#107064)
mementum pushed a commit to mementum/cpython that referenced this pull request Jul 23, 2023
@vstinner @mementum
pythongh-106320: Move _PyMethodWrapper_Type to internal C API (python…
f1dac17 
…#107064)
@pmiloslavsky

pmiloslavsky commented Nov 12, 2024

Copy link
Copy Markdown

Hi Victor, we were using _PyMethodWrapper_Type in our C extension code, what can we check now?

if (mthd && PyObject_TypeCheck(mthd, &_PyMethodWrapper_Type)) {
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Nov 12, 2024

Copy link
Copy Markdown
Member Author

Hi Victor, we were using _PyMethodWrapper_Type in our C extension code, what can we check now?

You can get the type from the Python module types.MethodWrapperType.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @pmiloslavsky @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.