GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-107091: Fix some uses of :c:type: role by serhiy-storchaka · Pull Request #107138 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 23, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Use the C domain roles consistently in the documentation #107091

📚 Documentation preview 📚: https://cpython-previews--107138.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-107091: Fix some uses of :c:type: role
848c946
@serhiy-storchaka serhiy-storchaka added docs Documentation in the Doc dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 23, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 23, 2023
Use the C domain roles consistently in the documentation #107091
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Jul 23, 2023
hugovk
hugovk reviewed Jul 24, 2023
View reviewed changes
Comment thread Doc/c-api/typeobj.rst
.. [#cols] Columns:

**"O"**: set on :c:type:`PyBaseObject_Type`
**"O"**: set on :c:data:`PyBaseObject_Type`

@hugovk hugovk Jul 24, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:c:data:`PyBaseObject_Type` is also not found. Can it be documented or ab alternative used?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@serhiy-storchaka serhiy-storchaka Jul 25, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is not currently documented. But this out of scope of this PR which simply fixes markup. When it be documented, all these reference will instantly became links.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@serhiy-storchaka
serhiy-storchaka merged commit 6d5b6e7 into python:main Jul 26, 2023
@miss-islington

miss-islington commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 26, 2023
@serhiy-storchaka
serhiy-storchaka deleted the docs-c-type-role branch July 26, 2023 19:29
@bedevere-bot

bedevere-bot commented Jul 26, 2023

Copy link
Copy Markdown

GH-107312 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 26, 2023
@serhiy-storchaka @miss-islington
pythongh-107091: Fix some uses of :c:type: role (pythonGH-107138)
95b1207 
(cherry picked from commit 6d5b6e7)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 26, 2023
@bedevere-bot

bedevere-bot commented Jul 26, 2023

Copy link
Copy Markdown

GH-107313 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 26, 2023
@serhiy-storchaka @miss-islington
pythongh-107091: Fix some uses of :c:type: role (pythonGH-107138)
2fdfb85 
(cherry picked from commit 6d5b6e7)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 26, 2023
serhiy-storchaka added a commit that referenced this pull request Jul 26, 2023
@miss-islington @serhiy-storchaka
[3.12] gh-107091: Fix some uses of :c:type: role (GH-107138) (GH-107312)
da2097d 
(cherry picked from commit 6d5b6e7)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Jul 26, 2023
@miss-islington @serhiy-storchaka
[3.11] gh-107091: Fix some uses of :c:type: role (GH-107138) (GH-107313)
603c5d5 
(cherry picked from commit 6d5b6e7)

Co-authored-by: Serhiy Storchaka <[email protected]>
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
@serhiy-storchaka @jtcave
pythongh-107091: Fix some uses of :c:type: role (pythonGH-107138)
f920e81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @miss-islington @bedevere-bot @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.