GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-107178: Add the C API tests for the Abstract Objects Layer by serhiy-storchaka · Pull Request #107179 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 24, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Cover all the Mapping Protocol, almost all the Sequence Protocol (except PySequence_Fast) and a part of the Object Protocol.

Move existing tests to Lib/test/test_capi/test_abstract.py and Modules/_testcapi/abstract.c.

  • Issue: Add the C API tests for Mapping Protocol and Sequence Protocol #107178

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland and gpshead reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@serhiy-storchaka
pythongh-107178: Add the C API tests for the Abstract Objects Layer
d553110 
Cover all the Mapping Protocol, almost all the Sequence Protocol
(except PySequence_Fast) and a part of the Object Protocol.

Move existing tests to Lib/test/test_capi/test_abstract.py and
Modules/_testcapi/abstract.c.
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir topic-C-API needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 24, 2023
@serhiy-storchaka
serhiy-storchaka requested a review from a team as a code owner July 24, 2023 14:01
@bedevere-bot bedevere-bot mentioned this pull request Jul 24, 2023
Add the C API tests for Mapping Protocol and Sequence Protocol #107178
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Jul 24, 2023
@serhiy-storchaka
Fix some errors.
5c0ce18
@serhiy-storchaka
serhiy-storchaka requested review from encukou, erlend-aasland and vstinner and removed request for a team July 25, 2023 07:32
@erlend-aasland

erlend-aasland commented Jul 25, 2023

Copy link
Copy Markdown
Contributor

Great work! I won't be able to review this until next week.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
Add also tests for PyDict C API.
bbe1ce2
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jul 25, 2023
C API: Add PyDict_GetItemRef() function #106004
Closed
serhiy-storchaka added 2 commits August 7, 2023 17:49
@serhiy-storchaka
Merge branch 'main' into test-capi-abstract
52f450d
@serhiy-storchaka
Cleanup.
594bd3c
@serhiy-storchaka serhiy-storchaka removed needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Aug 7, 2023
@serhiy-storchaka
serhiy-storchaka merged commit 16c9415 into python:main Aug 7, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 7, 2023
@serhiy-storchaka
serhiy-storchaka deleted the test-capi-abstract branch August 7, 2023 15:51
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Aug 7, 2023
@serhiy-storchaka
[3.12] pythongh-107178: Add the C API tests for the Abstract Objects …
6e9cbc9 
…Layer (pythonGH-107179)

Cover all the Mapping Protocol, almost all the Sequence Protocol
(except PySequence_Fast) and a part of the Object Protocol.

Move existing tests to Lib/test/test_capi/test_abstract.py and
Modules/_testcapi/abstract.c.

Add also tests for PyDict C API..
(cherry picked from commit 16c9415)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot

bedevere-bot commented Aug 7, 2023

Copy link
Copy Markdown

GH-107728 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Yhg1s pushed a commit that referenced this pull request Aug 16, 2023
@serhiy-storchaka
[3.12] gh-107178: Add the C API tests for the Abstract Objects Layer (G…
9c8dfce 
…H-107179) (#107728)

Cover all the Mapping Protocol, almost all the Sequence Protocol
(except PySequence_Fast) and a part of the Object Protocol.

Move existing tests to Lib/test/test_capi/test_abstract.py and
Modules/_testcapi/abstract.c.

Add also tests for PyDict C API..
(cherry picked from commit 16c9415)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner
@encukou encukou Awaiting requested review from encukou
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.