GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-96803: Move PyUnstable_InterpreterFrame_GetCode() to Python.h by vstinner · Pull Request #107188 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jul 24, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Declare the following 3 PyUnstable functions in
Include/cpython/pyframe.h rather than Include/cpython/frameobject.h, so they are now provided by the standard "#include <Python.h>".

  • Issue: Expose _PyInterpreterFrame_GetLine in the private API #96803

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added skip news needs backport to 3.12 only security fixes labels Jul 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 24, 2023
Expose _PyInterpreterFrame_GetLine in the private API #96803
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Jul 24, 2023
@vstinner
pythonGH-96803: Move PyUnstable_InterpreterFrame_GetCode() to Python.h
debe329 
Declare the following 3 PyUnstable functions in
Include/cpython/pyframe.h rather than Include/cpython/frameobject.h,
so they are now provided by the standard "#include <Python.h>".
@vstinner
vstinner force-pushed the pyunstable_frame branch from dda1d19 to debe329 Compare July 24, 2023 18:35
@vstinner

vstinner commented Jul 24, 2023

Copy link
Copy Markdown
Member Author

The commit a0df9ee added these 3 functions to "frameobject.h". The problem is that this header file is not included by Python.h. This change moves the functions to "pyframe.h" which is included by Python.h.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jul 24, 2023

Copy link
Copy Markdown
Member Author

cc @markshannon
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 837fa5c into python:main Jul 24, 2023
@miss-islington

miss-islington commented Jul 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 24, 2023
@vstinner
vstinner deleted the pyunstable_frame branch July 24, 2023 19:20
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 24, 2023
@vstinner @miss-islington
pythonGH-96803: Move PyUnstable_InterpreterFrame_GetCode() to Python.h (
89ff7bd 
pythonGH-107188)

Declare the following 3 PyUnstable functions in
Include/cpython/pyframe.h rather than Include/cpython/frameobject.h,
so they are now provided by the standard "GH-include <Python.h>".
(cherry picked from commit 837fa5c)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 24, 2023

Copy link
Copy Markdown

GH-107195 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 24, 2023
vstinner added a commit that referenced this pull request Jul 24, 2023
@miss-islington @vstinner
[3.12] GH-96803: Move PyUnstable_InterpreterFrame_GetCode() to Python…
f573a6a 
….h (GH-107188) (#107195)

GH-96803: Move PyUnstable_InterpreterFrame_GetCode() to Python.h (GH-107188)

Declare the following 3 PyUnstable functions in
Include/cpython/pyframe.h rather than Include/cpython/frameobject.h,
so they are now provided by the standard "GH-include <Python.h>".
(cherry picked from commit 837fa5c)

Co-authored-by: Victor Stinner <[email protected]>
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
@vstinner @jtcave
pythonGH-96803: Move PyUnstable_InterpreterFrame_GetCode() to Python.h (
654956f 
python#107188)

Declare the following 3 PyUnstable functions in
Include/cpython/pyframe.h rather than Include/cpython/frameobject.h,
so they are now provided by the standard "#include <Python.h>".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.