GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-106368: Increase Argument Clinic CLI test coverage (GH-107156) by miss-islington · Pull Request #107190 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 24, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Instead of hacking into the Clinic class, use the Argument Clinic tool
to run the ClinicExternalTest test suite.

(cherry picked from commit 83a2837)

Co-authored-by: Erlend E. Aasland [email protected]
Co-authored-by: Nikita Sobolev [email protected]

  • Issue: Increase Argument Clinic test coverage #106368

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland @sobolevn @miss-islington
pythongh-106368: Increase Argument Clinic CLI test coverage (pythonGH…
bd0c8b6 
…-107156)

Instead of hacking into the Clinic class, use the Argument Clinic tool
to run the ClinicExternalTest test suite.

(cherry picked from commit 83a2837)

Co-authored-by: Erlend E. Aasland <[email protected]>
Co-authored-by: Nikita Sobolev <[email protected]>
This was referenced Jul 24, 2023
Increase Argument Clinic test coverage #106368
Closed
gh-106368: Increase Argument Clinic CLI test coverage #107156
Merged
@bedevere-bot bedevere-bot added skip news awaiting review tests Tests in the Lib/test dir labels Jul 24, 2023
erlend-aasland
erlend-aasland approved these changes Jul 24, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jul 24, 2023
@erlend-aasland
erlend-aasland enabled auto-merge (squash) July 24, 2023 18:56
erlend-aasland
erlend-aasland reviewed Jul 26, 2023
View reviewed changes
Comment thread Lib/test/test_clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland and others added 2 commits July 26, 2023 23:02
@erlend-aasland
NoneType was removed in 3.12, so it exists in 3.11
a340685
@erlend-aasland
Merge branch '3.11' into backport-83a2837-3.11
0f8736f
erlend-aasland
erlend-aasland reviewed Jul 26, 2023
View reviewed changes
Comment thread Lib/test/test_clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
3.11 has a different checksum
2e1e628
@erlend-aasland
erlend-aasland disabled auto-merge July 26, 2023 22:36
@erlend-aasland
erlend-aasland merged commit 6bf2c29 into python:3.11 Jul 26, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 26, 2023
@miss-islington
miss-islington deleted the backport-83a2837-3.11 branch July 26, 2023 22:37
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jul 26, 2023
@miss-islington @erlend-aasland @sobolevn
[3.11] pythongh-106368: Increase Argument Clinic CLI test coverage (p…
cebe60b 
…ythonGH-107156) (python#107190)

Instead of hacking into the Clinic class, use the Argument Clinic tool
to run the ClinicExternalTest test suite.

(cherry picked from commit 83a2837)

Co-authored-by: Erlend E. Aasland <[email protected]>
Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.