GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104050: Argument clinic: misc improvements to type annotation coverage by AlexWaygood · Pull Request #107206 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Jul 24, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Gets us down to 22 remaining errors if you run mypy with --disallow-untyped-defs!

  • Issue: Add type annotations to clinic.py #104050

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@AlexWaygood
Argument clinic: misc improvements to type annotation coverage
e3190c4
@AlexWaygood AlexWaygood added the skip news label Jul 24, 2023
@AlexWaygood
AlexWaygood requested a review from erlend-aasland as a code owner July 24, 2023 20:40
@bedevere-bot bedevere-bot mentioned this pull request Jul 24, 2023
Add type annotations to clinic.py #104050
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Jul 24, 2023
@AlexWaygood AlexWaygood mentioned this pull request Jul 24, 2023
gh-104050: Argument Clinic: Annotate CRenderData.__init__ #107207
Merged
erlend-aasland
erlend-aasland reviewed Jul 24, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py
# these F spaces will be stripped.
def state_parameter_docstring(self, line):
def state_parameter_docstring(self, line: str | None) -> None:
assert line is not None

@erlend-aasland erlend-aasland Jul 24, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to get rid of these at some point.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
erlend-aasland
erlend-aasland approved these changes Jul 24, 2023
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 24, 2023
@AlexWaygood
AlexWaygood enabled auto-merge (squash) July 24, 2023 21:20
@AlexWaygood
AlexWaygood merged commit d93fe5a into python:main Jul 24, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 24, 2023
@AlexWaygood
AlexWaygood deleted the clinic-type-coverage branch July 26, 2023 10:09
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
@AlexWaygood @jtcave
pythongh-104050: Argument clinic: misc improvements to type annotatio…
14ab264 
…n coverage (python#107206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AlexWaygood @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.