GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-107211: Rename PySymtable_Lookup() to _PySymtable_Lookup() by vstinner · Pull Request #107212 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jul 25, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Rename the internal PySymtable_Lookup() function to _PySymtable_Lookup() and no longer export it.

  • Issue: C API: No longer export internal C API functions #107211

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-107211: Rename PySymtable_Lookup() to _PySymtable_Lookup()
3ba33ba 
Rename the internal PySymtable_Lookup() function to
_PySymtable_Lookup() and no longer export it.
@vstinner vstinner added skip news topic-C-API labels Jul 25, 2023
@vstinner
vstinner requested review from iritkatriel and markshannon as code owners July 25, 2023 00:10
@bedevere-bot bedevere-bot mentioned this pull request Jul 25, 2023
C API: No longer export internal C API functions #107211
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Jul 25, 2023
@vstinner
vstinner enabled auto-merge (squash) July 25, 2023 00:20
@vstinner
vstinner merged commit 2e07449 into python:main Jul 25, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 25, 2023
@vstinner
vstinner deleted the symtable_lookup branch July 25, 2023 01:08
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
@vstinner @jtcave
pythongh-107211: Rename PySymtable_Lookup() to _PySymtable_Lookup() (p…
2478742 
…ython#107212)

Rename the internal PySymtable_Lookup() function to
_PySymtable_Lookup() and no longer export it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.