GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-107211: No longer export internal variables by vstinner · Pull Request #107218 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jul 25, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

No longer export these 5 internal C API variables:

  • _PyBufferWrapper_Type
  • _PyImport_FrozenBootstrap
  • _PyImport_FrozenStdlib
  • _PyImport_FrozenTest
  • _Py_SwappedOp

Fix definition of these internal functions, replace PyAPI_DATA() with PyAPI_FUNC():

  • _PyImport_ClearExtension()
  • _PyObject_IsFreed()
  • _PyThreadState_GetCurrent()
  • Issue: C API: No longer export internal C API functions #107211

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added skip news topic-C-API labels Jul 25, 2023
@vstinner
vstinner requested review from brettcannon, ericsnowcurrently, ncoghlan, tiran and warsaw as code owners July 25, 2023 02:45
@bedevere-bot bedevere-bot mentioned this pull request Jul 25, 2023
C API: No longer export internal C API functions #107211
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Jul 25, 2023
@vstinner
vstinner enabled auto-merge (squash) July 25, 2023 02:46
@vstinner
pythongh-107211: No longer export internal variables
ae0c33c 
No longer export _PyBufferWrapper_Type internal C API variable.

Fix definition of these internal functions, replace PyAPI_DATA() with
PyAPI_FUNC():

* _PyImport_ClearExtension()
* _PyObject_IsFreed()
* _PyThreadState_GetCurrent()
@vstinner
vstinner force-pushed the extern_data branch from 1a66f65 to ae0c33c Compare July 25, 2023 03:06
@vstinner
vstinner merged commit 3b30931 into python:main Jul 25, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 25, 2023
@vstinner
vstinner deleted the extern_data branch July 25, 2023 03:51
@vstinner

vstinner commented Jul 25, 2023

Copy link
Copy Markdown
Member Author

Oh, sadly the commit message is wrong. At the end, only _PyBufferWrapper_Type is no longer exported.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
@vstinner @jtcave
pythongh-107211: No longer export internal variables (python#107218)
f052817 
No longer export these 5 internal C API variables:

* _PyBufferWrapper_Type
* _PyImport_FrozenBootstrap
* _PyImport_FrozenStdlib
* _PyImport_FrozenTest
* _Py_SwappedOp

Fix the definition of these internal functions, replace PyAPI_DATA()
with PyAPI_FUNC():

* _PyImport_ClearExtension()
* _PyObject_IsFreed()
* _PyThreadState_GetCurrent()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@tiran tiran Awaiting requested review from tiran

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.