GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106004: PyDict_GetItemRef() should only be in the limited API 3.13 by serhiy-storchaka · Pull Request #107229 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 25, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: C API: Add PyDict_GetItemRef() function #106004

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka serhiy-storchaka added skip news topic-C-API labels Jul 25, 2023
@serhiy-storchaka
serhiy-storchaka requested a review from vstinner July 25, 2023 10:48
@bedevere-bot bedevere-bot added the awaiting core review label Jul 25, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 21, 2023
C API: Add PyDict_GetItemRef() function #106004
Closed
@serhiy-storchaka
serhiy-storchaka force-pushed the limited-capi-PyDict_GetItemRef branch from b0233b5 to 4210c15 Compare July 25, 2023 10:49
vstinner
vstinner reviewed Jul 25, 2023
View reviewed changes
Comment thread Include/dictobject.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jul 25, 2023

Copy link
Copy Markdown
Member

Oh sorry, I always forget to pay attention to versionning when adding a function to the limited C API.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka changed the title gh-106004: PyDict_GetItemRef() should only be in the limited API 3.13 gh-106004: PyDict_GetItemRef() should only be in the limited API 3.10 Jul 25, 2023
@serhiy-storchaka serhiy-storchaka changed the title gh-106004: PyDict_GetItemRef() should only be in the limited API 3.10 gh-106004: PyDict_GetItemRef() should only be in the limited API 3.13 Jul 25, 2023
@serhiy-storchaka
pythongh-106004: PyDict_GetItemRef() should only be in the limited AP…
6730eec 
…I 3.13
@serhiy-storchaka
serhiy-storchaka force-pushed the limited-capi-PyDict_GetItemRef branch from 4210c15 to 6730eec Compare July 25, 2023 11:07
vstinner
vstinner approved these changes Jul 25, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 25, 2023
@serhiy-storchaka
serhiy-storchaka merged commit 2b1a81e into python:main Jul 25, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 25, 2023
@serhiy-storchaka
serhiy-storchaka deleted the limited-capi-PyDict_GetItemRef branch July 25, 2023 18:48
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
@serhiy-storchaka @jtcave
pythongh-106004: PyDict_GetItemRef() should only be in the limited AP…
af34f7d 
…I 3.13 (pythonGH-107229)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.