GeezerVison

@ericsnowcurrently: Here is a PR to remove _PyImport_GetModuleId().

FTR, here's Victor's PyPI search: #107213 (comment)

Hum, the CLA Signing job was blocked. So I closed/reopened my PR and also rebased it on the main branch. Let's see if this time, the job starts.

docs/readthedocs.org:cpython-previews — Read the Docs build failed!

Strange. Python .readthedocs.yaml uses exit 183 if the Python Documentation was not changed and so it's not needed to build the documentation, and this exit code is documented by ReadTheDocs as "skip the build"

Strange. Python .readthedocs.yaml uses exit 183 if the Python Documentation was not changed and so it's not needed to build the documentation, and this exit code is documented by ReadTheDocs as "skip the build"

I reported the issue to ReadTheDocs bug tracker: readthedocs/readthedocs.org#10567

Assuming no external modules (or embedders) are using this, LGTM.

I checked again: I found no user in PyPI top 5,000 projects (2023-07-04):

$ ./search_pypi_top.py PYPI-2023-07-04/ '_PyImport_GetModuleId' -q
PYPI-2023-07-04/fastobo-0.12.2.tar.gz: fastobo-0.12.2/crates/pyo3-ffi/src/cpython/import.rs: // skipped _PyImport_GetModuleId
PYPI-2023-07-04/orjson-3.9.1.tar.gz: orjson-3.9.1/include/cargo/pyo3-ffi-0.19.0/src/cpython/import.rs: // skipped _PyImport_GetModuleId

Time: 0:00:39.023925
Found 2 matching lines in 2 projects

The 2 results are only comments to say that PyO3-ffi has no binding for _PyImport_GetModuleId().

I closed/reopened again the PR to trigger a new ReadTheDocs job. Right now, the job is failing with:

Concurrency limit reached (2), retrying in 5 minutes.

Merged, thanks for the review @ericsnowcurrently.