GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104050: Argument clinic: more misc typing improvements by AlexWaygood · Pull Request #107264 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Jul 25, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Add type annotations to clinic.py #104050

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@AlexWaygood
Argument clinic: more misc typing improvements
499fd9a
@AlexWaygood AlexWaygood added the skip news label Jul 25, 2023
@AlexWaygood
AlexWaygood requested a review from erlend-aasland as a code owner July 25, 2023 19:43
@bedevere-bot bedevere-bot added the awaiting core review label Jul 25, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 25, 2023
Add type annotations to clinic.py #104050
Closed
AlexWaygood
AlexWaygood commented Jul 25, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py
Comment on lines +2698 to +2703
def __init__(
cls, name: str, bases: tuple[type, ...], classdict: dict[str, Any]
) -> None:
converter_cls = cast(type["CConverter"], cls)
add_c_converter(converter_cls)
add_default_legacy_c_converter(converter_cls)

@AlexWaygood AlexWaygood Jul 25, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mypy was complaining because our type annotation for add_c_converter says (correctly) that the argument passed in has to be a subclass of CConverter. But that isn't necessarily true here, since this metaclass could theoretically be used with classes other than CConverter (it isn't, and it won't be, but mypy doesn't know that).

Ideally we could do this:

    def __init__(
        cls, name: str, bases: tuple[type, ...], classdict: dict[str, Any]
    ) -> None:
        assert issubclass(cls, CConverter)
        add_c_converter(cls)
        add_default_legacy_c_converter(cls)

But we can't... because if cls is CConverter itself, then at this point, CConverter doesn't exist in the global namespace yet! So that would fail with NameError.

I therefore elected to use typing.cast() to just tell mypy to go away here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with eyes emoji
All reactions
  • 👀 1 reaction

@erlend-aasland erlend-aasland Jul 25, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing these excellent explanations!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 1 reaction

@AlexWaygood AlexWaygood Jul 25, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad they're all making sense! :D

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
erlend-aasland
erlend-aasland approved these changes Jul 25, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 25, 2023
@AlexWaygood
AlexWaygood merged commit ee90107 into python:main Jul 25, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 25, 2023
@AlexWaygood
AlexWaygood deleted the misc-clinic-typing branch July 25, 2023 21:08
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
@AlexWaygood @jtcave
pythongh-104050: Argument clinic: more misc typing improvements (pyth…
3a4bb49
…on#107264)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AlexWaygood @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.