GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-101524: Only Use Public C-API in the _xxsubinterpreters Module (gh-105258) by miss-islington · Pull Request #107303 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 26, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The _xxsubinterpreters module was meant to only use public API. Some internal C-API usage snuck in over the last few years (e.g. gh-28969). This fixes that.
(cherry picked from commit e6373c0)

Co-authored-by: Eric Snow [email protected]

  • Issue: Maybe Drop "channels" from _xxsubinterpreters #101524

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ericsnowcurrently @miss-islington
pythongh-101524: Only Use Public C-API in the _xxsubinterpreters Modu…
f1e88f8
…le (pythongh-105258)

The _xxsubinterpreters module was meant to only use public API.  Some internal C-API usage snuck in over the last few years (e.g. pythongh-28969).  This fixes that.
(cherry picked from commit e6373c0)

Co-authored-by: Eric Snow <[email protected]>
@miss-islington
miss-islington requested a review from a team as a code owner July 26, 2023 17:14
This was referenced Jul 26, 2023
Maybe Drop "channels" from _xxsubinterpreters #101524
Closed
gh-101524: Only Use Public C-API in the _xxsubinterpreters Module #105258
Merged
@bedevere-bot bedevere-bot added skip news awaiting review labels Jul 26, 2023
@ericsnowcurrently
Fix _testinternalcapi.c.
c2732ba
@ericsnowcurrently
ericsnowcurrently requested review from Yhg1s and removed request for a team July 26, 2023 17:18
@ericsnowcurrently

ericsnowcurrently commented Jul 26, 2023

Copy link
Copy Markdown
Member

This change allows me to independently build the _xxsubinterpreters module against 3.12 without Py_BUILD_CORE, for publishing to PyPI.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Yhg1s
Yhg1s reviewed Jul 27, 2023
View reviewed changes
Comment thread Modules/_xxinterpchannelsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Yhg1s
Yhg1s approved these changes Jul 27, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jul 27, 2023
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) July 27, 2023 19:15
@ericsnowcurrently
ericsnowcurrently merged commit 57ef065 into python:3.12 Jul 27, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 27, 2023
@miss-islington
miss-islington deleted the backport-e6373c0-3.12 branch July 27, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently left review comments
@Yhg1s Yhg1s Yhg1s approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @ericsnowcurrently @Yhg1s @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.